Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICA Client testing #486

Draft
wants to merge 51 commits into
base: main
Choose a base branch
from
Draft

ICA Client testing #486

wants to merge 51 commits into from

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Oct 7, 2024 •
edited
Loading

This Pr aims at moving and testing the ICA client based on Abstract V2.

  • ICA Client is a native module for now but is not installable by users (The IBC Client is the only native module that can be installed)
  • ICA Client has a lot of pre-requisites to work (it necessitates IBC channels and IBC forwarder)
  • It is dependent on the EVM note being registered inside abstract.
    • Should we create a deployment flow that includes both to make sure everything is registered when deploying abstract ?
    • I think that the deployment flow of the ICA client and the Polytone EVM implementation need to follow the exact same flow as our current Polytone and Abstract flow

Testing is extremely limited because UNION is VERY SLOW to commit packets receive and acks.

The file containing the test can be found here: https://github.com/AbstractSDK/abstract/pull/486/files#diff-91fd048063bac99685bc53380e57097196063977ab6782ecd820c3d759b2eeea

Checklist

  • CI is green.
  • Changelog updated.

@Kayanski Kayanski mentioned this pull request Oct 7, 2024
Closed
2 tasks
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 7, 2024 •
edited
Loading

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1d4f0a8
Status: ✅  Deploy successful!
Preview URL: https://7cfb1d95.abstract-docs.pages.dev
Branch Preview URL: https://ica-client-tests-move.abstract-docs.pages.dev

View logs

Kayanski and others added 12 commits October 8, 2024 09:34
@Kayanski
Fix and update
421021c
@Kayanski
Update cw-orch cw-orch-interchain, polytone
743af86
@Kayanski
formatting [skip ci]
340ab11
@Kayanski
Merge branch 'develop/v2' into nicolas/abs-534-review-interchain-abst…
279e7b1 
…ract-testing-setup-for-interchain-v2
@Kayanski
Re-added cw-orch-proto dependent tests
00d6584
@Kayanski
Merge branch 'nicolas/abs-534-review-interchain-abstract-testing-setu…
452add9 
…p-for-interchain-v2' of github.com:AbstractSDK/abstract into nicolas/abs-534-review-interchain-abstract-testing-setup-for-interchain-v2
@Kayanski
Merge remote-tracking branch 'origin/nicolas/abs-534-review-interchai…
42b837b 
…n-abstract-testing-setup-for-interchain-v2' into ica-client/tests-move
@Buckram123
small-wasm
ba0fd34
@Kayanski
compiling wasm
b7e9d8c
@Buckram123
remove ibc client message
1f41822
@Buckram123
Avoid usage of instantiate msg for sub account creation
b253c0a
@Kayanski
Final ica client test
836f3b4
@Kayanski Kayanski changed the base branch from develop/v2 to v2/small-wasm October 9, 2024 13:40
Base automatically changed from v2/small-wasm to develop/v2 October 10, 2024 10:52
Buckram123 and others added 14 commits October 11, 2024 10:52
@Buckram123
helper for interchain client mock
10e3e30
@Buckram123
add admin assertion
1116360
@Kayanski
Added call as to interface and client
72a628a
@Kayanski
Merge branch 'nicolas/abs-534-review-interchain-abstract-testing-setu…
dcd2071 
…p-for-interchain-v2' of github.com:AbstractSDK/abstract into nicolas/abs-534-review-interchain-abstract-testing-setup-for-interchain-v2
@Kayanski
Fix interchain clippyé
4e62a5d 
gop
@Kayanski
Funds in test
ee82171
@Kayanski
Moved send back logic
ddf335e
@Kayanski
Merge remote-tracking branch 'origin/develop/v2' into nicolas/abs-534…
b67edb4 
…-review-interchain-abstract-testing-setup-for-interchain-v2
@Kayanski
Merge remote-tracking branch 'origin/nicolas/abs-534-review-interchai…
3f6ee36 
…n-abstract-testing-setup-for-interchain-v2' into ica-client/tests-move
@Kayanski
Fix
104741b
@Kayanski
More helpers in remote crate
8f92c2d
@Kayanski
Merge remote-tracking branch 'origin/develop/v2' into ica-client/test…
eccad1f 
…s-move
@Kayanski
Restore union deployment
bb21968
@Kayanski
Fixes and state
29e5a79
Base automatically changed from develop/v2 to main October 16, 2024 13:11
Buckram123
Buckram123 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Would be nice to update chain type lookup table, other than that small nits 🚀

framework/Cargo.toml Outdated Show resolved Hide resolved
framework/contracts/native/ica-client/src/queries.rs Outdated Show resolved Hide resolved
framework/Cargo.toml Outdated Show resolved Hide resolved
framework/packages/abstract-std/src/native/ibc/ica_client.rs Outdated Show resolved Hide resolved
framework/packages/abstract-std/src/native/ibc/ica_client.rs Outdated Show resolved Hide resolved
framework/packages/abstract-std/src/native/ibc/ica_client.rs Show resolved Hide resolved
interchain/interchain-end_to_end_testing/src/bin/gov-prop-abstract.rs Outdated Show resolved Hide resolved
scripts/wasm-framework.sh Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Buckram123 Buckram123 Buckram123 approved these changes

Assignees
No one assigned
Labels
account interface native
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kayanski @Buckram123 @CyberHoward