ABS-166: Create accountability module

[0xmovses]

Description

See the original ticket ABS-166.

The main purpose of this was to get familiar with the SDK and create a new module end-to-end. I tried to keep the implementation as simple as possible for this reason. Whilst creating the module several things came up as possible enhancements that may want to be added before merging. Also I took some notes about some areas where we could have nicer doc comments and api improvements.

This is work to lay the foundation for a forthcoming Tutorial section in the docs, which would guide a developer through writing a module end-to-end.

Changelog

• Created a new module under /apps/challenge
• Created a new cosmwasm smart contract, handlers, error and msg.
• Created two test files wasm.rs and integration.rs.

Testing

• I tested deploying the wasm bin contract
• There are 11 new integration tests for the contract. You can run them with just test

Enhancements / Considerations

• After PR review I'll generate the schemas.
• In general if this was intended to be used on mainnet I would want to write more elaborate tests, coming up with various edge cases.
• Incentivisation Mechanic: Where if the admin complete's the challenge, they get some token (fungible or non)
• Croncat functionality
  • There are several ways we may want to add functionality for this. One way is to use Croncat to periodically call count_votes
  • On a call with Adair yesterday we added the type :

#[cosmwasm_schema::cw_serde]
pub enum Penalty {
   FixedAmount {
       asset: OfferAsset,
   },
   Daily {
       asset: OfferAsset,
       split_between_friends: bool,
   },
}

I'm not sure exactly what the functionality should be for Daily. Is it that the total collateral is divided among the total days for the challenge and distributed equally to all friends every time there is a false vote? If yes I will need to add a field for ChallengeEntry that keeps track of total days and add more tests for this.

• Proof of Challenge.
  • Another idea we had was to add some functionality that allows the admin to prove they completed their challenge. For example uploading a picture of them bench pressing ;) thusly becoming the greatest NFT ever.

CI

I've incorporated clippy changes but I am seeing some other tests failing:

test osmosis_test::stake_lp ... FAILED
test osmosis_test::claim_all ... FAILED
test osmosis_test::staking_inited ... FAILED
test osmosis_test::unstake_lp ... FAILED

Any ideas why this might be?

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	5d26c7e
Status:	✅  Deploy successful!
Preview URL:	https://1061924c.abstract-docs.pages.dev
Branch Preview URL:	https://0xmovses-abs-166.abstract-docs.pages.dev

View logs

[Buckram123]

LFG, that will be last nits, I promise!

[CyberHoward]

@0xmovses chrono needs to be <= v0.4.27. See:
osmosis-labs/osmosis-rust#87

[Buckram123]

LFG

[codecov-commenter]

Codecov Report

Merging #47 (5d26c7e) into main (7c9c262) will increase coverage by 18.11%.
Report is 117 commits behind head on main.
The diff coverage is 48.01%.

@@             Coverage Diff             @@
##             main      #47       +/-   ##
===========================================
+ Coverage   24.28%   42.39%   +18.11%     
===========================================
  Files         266      222       -44     
  Lines       23391    16748     -6643     
===========================================
+ Hits         5680     7100     +1420     
+ Misses      17711     9648     -8063     

Files Changed	Coverage Δ
framework/contracts/account/manager/src/error.rs	0.00% <ø> (ø)
framework/contracts/account/manager/src/queries.rs	51.45% <0.00%> (+15.90%)	⬆️
...k/contracts/native/version-control/src/contract.rs	47.31% <0.00%> (+0.99%)	⬆️
...work/contracts/native/version-control/src/error.rs	25.00% <ø> (ø)
framework/packages/abstract-adapter/src/state.rs	5.55% <ø> (ø)
framework/packages/abstract-app/src/endpoints.rs	0.00% <ø> (ø)
...ork/packages/abstract-app/src/endpoints/execute.rs	26.19% <0.00%> (-0.84%)	⬇️
framework/packages/abstract-app/src/features.rs	70.00% <0.00%> (-30.00%)	⬇️
framework/packages/abstract-app/src/state.rs	5.55% <ø> (-94.45%)	⬇️
framework/packages/abstract-core/src/adapter.rs	60.60% <ø> (+15.15%)	⬆️
... and 48 more

... and 102 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

All requested changes integrated. Still asking me for one requested change, not sure what it is.