Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memo field apis #412

Merged
merged 37 commits into from
Oct 25, 2024
Merged

Memo field apis #412

merged 37 commits into from
Oct 25, 2024

Conversation

Buckram123
Copy link
Collaborator

@Buckram123 Buckram123 commented Jul 18, 2024

  • Packet forward middleware
  • Ibc Hooks

Checklist

  • CI is green.
  • Changelog updated.

@github-actions github-actions bot added documentation Improvements or additions to documentation native sdk labels Jul 18, 2024
Copy link

cloudflare-workers-and-pages bot commented Jul 18, 2024

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ca4e6ff
Status: ✅  Deploy successful!
Preview URL: https://c99fc0cf.abstract-docs.pages.dev
Branch Preview URL: https://misha-abs-464-memo-field-api.abstract-docs.pages.dev

View logs

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 81 lines in your changes missing coverage. Please review.

Project coverage is 35.4%. Comparing base (c1c8edf) to head (5b53d78).
Report is 1 commits behind head on buckram/cosmwasm-2.0-bump.

Files with missing lines Patch % Lines
...ork/packages/abstract-sdk/src/apis/ibc_memo/pfm.rs 0.0% 58 Missing ⚠️
...mework/contracts/native/ibc-client/src/commands.rs 0.0% 8 Missing ⚠️
...k/packages/abstract-sdk/src/apis/ibc_memo/hooks.rs 0.0% 8 Missing ⚠️
...mework/contracts/native/ibc-client/src/contract.rs 0.0% 2 Missing ⚠️
framework/packages/abstract-sdk/src/apis/ibc.rs 0.0% 2 Missing ⚠️
...s/abstract-client/src/interchain/remote_account.rs 0.0% 1 Missing ⚠️
...tracts/adapters/cw-staking/src/handlers/execute.rs 0.0% 1 Missing ⚠️
...les/contracts/adapters/dex/src/handlers/execute.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
framework/contracts/account/proxy/src/commands.rs 37.3% <ø> (ø)
...ork/packages/abstract-std/src/native/ibc_client.rs 55.3% <ø> (ø)
...s/abstract-client/src/interchain/remote_account.rs 35.0% <0.0%> (-0.1%) ⬇️
...tracts/adapters/cw-staking/src/handlers/execute.rs 0.0% <0.0%> (ø)
...les/contracts/adapters/dex/src/handlers/execute.rs 0.0% <0.0%> (ø)
...mework/contracts/native/ibc-client/src/contract.rs 64.6% <0.0%> (-0.7%) ⬇️
framework/packages/abstract-sdk/src/apis/ibc.rs 23.0% <0.0%> (-0.3%) ⬇️
...mework/contracts/native/ibc-client/src/commands.rs 61.6% <0.0%> (-0.5%) ⬇️
...k/packages/abstract-sdk/src/apis/ibc_memo/hooks.rs 0.0% <0.0%> (ø)
...ork/packages/abstract-sdk/src/apis/ibc_memo/pfm.rs 0.0% <0.0%> (ø)

@CyberHoward CyberHoward added the RFM Ready For Merge label Jul 23, 2024
@Buckram123
Copy link
Collaborator Author

Working right now on 3chain starship test with this to see if API should be improved

@Buckram123 Buckram123 marked this pull request as draft July 29, 2024 13:29
@Buckram123 Buckram123 removed the request for review from CyberHoward July 29, 2024 13:29
@Buckram123 Buckram123 marked this pull request as draft August 27, 2024 08:00
Copy link
Contributor

@CyberHoward CyberHoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to replace Juno with Osmosis in the starship tests.

framework/docs/src/releases/CHANGELOG.md Outdated Show resolved Hide resolved
framework/packages/abstract-sdk/src/apis/ibc_memo.rs Outdated Show resolved Hide resolved
framework/packages/abstract-sdk/src/apis/ibc_memo.rs Outdated Show resolved Hide resolved
starship setup

install:
starship start --config $(FILE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step already includes port-forwarding (inside starship start)

interchain/interchain-tests/src/setup.rs Outdated Show resolved Hide resolved
@Buckram123 Buckram123 changed the base branch from main to buckram/cosmwasm-2.0-bump September 6, 2024 08:52
@Buckram123 Buckram123 changed the base branch from buckram/cosmwasm-2.0-bump to main October 18, 2024 12:08
@Buckram123 Buckram123 marked this pull request as ready for review October 22, 2024 17:51
@Kayanski Kayanski merged commit 744539f into main Oct 25, 2024
16 of 24 checks passed
@Kayanski Kayanski deleted the misha/abs-464-memo-field-apis branch October 25, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
account documentation Improvements or additions to documentation interface native RFM Ready For Merge sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants