Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON property view: expand/collapse #645

Closed
wajda opened this issue Apr 21, 2020 · 4 comments
Closed

JSON property view: expand/collapse #645

wajda opened this issue Apr 21, 2020 · 4 comments
Assignees
Milestone

Comments

@wajda
Copy link
Contributor

wajda commented Apr 21, 2020

image

Properties JSON should be collapsible. By default, the 1st level should be expanded, 2nd and further layers should be collapsed.

@wajda wajda added this to the 0.6.0 milestone Apr 22, 2020
@wajda wajda modified the milestones: 0.6.0, 0.5.2 May 28, 2020
@wajda
Copy link
Contributor Author

wajda commented May 29, 2020

Also display non-empty properties for read and write operations.

@DaimonPl
Copy link
Contributor

Any chance to add it not only in json view, but also use full table name (database.table) in dependency graph?

@wajda
Copy link
Contributor Author

wajda commented May 31, 2020

Well, it's not that easy as it seems. Spline UI displays datasource URI, which in your case points to a Parquet file. The fact that the job actually read/wrote a Hive table mapped to a Parquet is specific to that exact job/cluster setup, and the UI has no knowledge of it.
I think what you need can be implemented by setting a custom user-friendly name for certain datasources, with which it would be displayed in the lineage graphs. Currently Spline doesn't have this feature, but in it will be added in a future version together with datasource management. I created an epic for this - #689
But for now displaying the database and table as properties of read/write operations is the only way.

@oleksandr-korchak
Copy link
Contributor

  • Display all extra fields which are in the properties object after the known.
    Props which are object or array should be displayed as an extra section.
    Section is collapsed by default for data types which are array or object.

Known properties for

General visible props:

  • name (shown at the top)

General Hidden

Logical Relation:

  • inputSources
  • sourceType

Write:

  • outputSource
  • destinationType
  • append

oleksandr-korchak added a commit that referenced this issue Jun 8, 2020
oleksandr-korchak added a commit that referenced this issue Jun 8, 2020
#645 :: Operation native properties for LogicalRelation & Write types operations.

#645 :: Extra Options for Read/Write operations.

#645 :: Extra params :: adjust titles styles.

#645 :: remove not used styles.

#645 :: adjust types definitions.

#645 :: License.

#645 :: Generic Operation props.
oleksandr-korchak added a commit that referenced this issue Jun 8, 2020
#645 :: Operation native properties for LogicalRelation & Write types operations.

#645 :: Extra Options for Read/Write operations.

#645 :: Extra params :: adjust titles styles.

#645 :: remove not used styles.

#645 :: adjust types definitions.

#645 :: License.

#645 :: Generic Operation props.
@wajda wajda closed this as completed Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants