fix #228 removed setTimeout and used ngOnInit #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
korel-san
reviewed
Feb 23, 2023
| @@ -117,12 +117,12 @@ export class EventOverviewStore extends BaseStore<EventOverviewStoreNs.State> { | |||
| graphLoadingProcessing: ProcessingStoreNs.eventProcessingStart(this.state.graphLoadingProcessing) | |||
| }) | |||
|
|
|||
| setTimeout(() => { | |||
|
|
|||
| this.updateState({ | |||
There was a problem hiding this comment.
@TerranceKhumalo-absa I would recommend investigating why the developer called 2 times this.updateState (and the second time he used setTimeout) for a better understanding of how to refactor this code correctly.
korel-san
reviewed
Feb 23, 2023
| @@ -132,12 +132,12 @@ export class EventOverviewStore extends BaseStore<EventOverviewStoreNs.State> { | |||
| graphLoadingProcessing: ProcessingStoreNs.eventProcessingStart(this.state.graphLoadingProcessing) | |||
| }) | |||
|
|
|||
| setTimeout(() => { | |||
There was a problem hiding this comment.
@TerranceKhumalo-absa same here
korel-san
suggested changes
Feb 23, 2023
Bumps [send](https://github.com/pillarjs/send) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together. Updates `send` from 0.18.0 to 0.19.0 - [Release notes](https://github.com/pillarjs/send/releases) - [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md) - [Commits](pillarjs/send@0.18.0...0.19.0) Updates `express` from 4.18.2 to 4.21.0 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md) - [Commits](expressjs/express@4.18.2...4.21.0) --- updated-dependencies: - dependency-name: send dependency-type: indirect - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
wajda
force-pushed
the
fix/228-setTimeout-refactor
branch
from
f1faab3
to
4a46843
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed setTimeout to initialize the values on ngOnInit instead.