Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring namespaces, that is deprecated in typescript #227

Closed
korel-san opened this issue Feb 14, 2023 · 0 comments
Closed

Refactoring namespaces, that is deprecated in typescript #227

korel-san opened this issue Feb 14, 2023 · 0 comments
Assignees
@TerranceKhumalo-absa
Labels
Tech debt
Milestone
1.0.0

Comments

@korel-san
Copy link
Contributor

Main goal: increase performance and make dependencies less tied, and increase code quality due to the removal of code duplications

The reason why is described here:
https://stackoverflow.com/questions/38582352/module-vs-namespace-import-vs-require-typescript#:~:text=A%20module%20in%20TypeScript%20is,code%20in%20an%20obsolete%20fashion.
@korel-san korel-san added this to the 1.0.0 milestone Feb 14, 2023
@korel-san korel-san self-assigned this Feb 14, 2023
@wajda wajda transferred this issue from AbsaOSS/spline Feb 14, 2023
TerranceKhumalo-absa added a commit that referenced this issue Feb 21, 2023
@TerranceKhumalo-absa
fix #227 refactor namespace to modules under src/modules/plans folder…
b00537a 
…. Remove unused export /operation-property.models
TerranceKhumalo-absa added a commit that referenced this issue Feb 22, 2023
@TerranceKhumalo-absa
fix #227 Add spaces between the import braces
f73604c
TerranceKhumalo-absa added a commit that referenced this issue Feb 22, 2023
@TerranceKhumalo-absa
fix #227 Fix indentation
ccfc6c5
TerranceKhumalo-absa added a commit that referenced this issue Feb 22, 2023
@TerranceKhumalo-absa
fix #227 Fix indentation in plan-overview.page.component.ts
5810a55
TerranceKhumalo-absa added a commit that referenced this issue Feb 22, 2023
@TerranceKhumalo-absa
fix #227 Fix indentation in operation-property.models.ts
539bcb9
TerranceKhumalo-absa added a commit that referenced this issue Feb 27, 2023
@TerranceKhumalo-absa
fix #227 refactor namespace plan-info.models.ts to plan-info.service.ts
a59eaf7
TerranceKhumalo-absa added a commit that referenced this issue Feb 27, 2023
@TerranceKhumalo-absa
fix #227 refactor add absa license and services imported
0022304
TerranceKhumalo-absa added a commit that referenced this issue Mar 7, 2023
@TerranceKhumalo-absa
fix #227 add module and service
eca77a2
wajda pushed a commit that referenced this issue Sep 18, 2024
@TerranceKhumalo-absa @wajda
fix #227 add module and service
b0f6625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TerranceKhumalo-absa TerranceKhumalo-absa

Labels
Tech debt
Projects
Spline
Status: Done
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@korel-san @TerranceKhumalo-absa