Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shade ANTLR runtime in the parser to avoid ANTLR potential incompatibility issues #680

Closed
yruslan opened this issue Jun 3, 2024 · 0 comments · Fixed by #682
Closed

Shade ANTLR runtime in the parser to avoid ANTLR potential incompatibility issues #680

yruslan opened this issue Jun 3, 2024 · 0 comments · Fixed by #682
Labels
enhancement New feature or request

Comments

@yruslan
Copy link
Collaborator

yruslan commented Jun 3, 2024

Background

Currently, COBOL parser generated code produced by ANTLR is exactly the same for all ANTLR versions supported by various Spark version starting from Spark 2.4.
But if fat JARs are not carefully generated by a user of Cobrix, ANTLR version included in the COBOL parser can conflict with Spark.

This has not yet been observed, but it is good thing to protect against future potential issues.

Feature

Shade ANTLR runtime in the parser to avoid ANTLR potential incompatibility issues.

Example [Optional]

--

Proposed Solution [Optional]

Investigate how sharing can be done in published artifact in sbt.
@yruslan yruslan added the enhancement New feature or request label Jun 3, 2024
yruslan added a commit that referenced this issue Jun 4, 2024
@yruslan
#680 Shade ANTLR for cobol-parser so that it won't clash with Spark's…
10db446 
… ANTLR runtime.

Also, the shading of dependent libraries is improved for 'sbt assembly'.
@yruslan yruslan mentioned this issue Jun 4, 2024
Merged
yruslan added a commit that referenced this issue Jun 4, 2024
@yruslan
#680 Shade ANTLR for cobol-parser so that it won't clash with Spark's…
0fdb861 
… ANTLR runtime.

Also, the shading of dependent libraries is improved for 'sbt assembly'.
@yruslan yruslan mentioned this issue Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#680 Shade ANTLR for cobol-parser so that it won't clash with Spark's ANTLR runtime. AbsaOSS/cobrix
1 participant
@yruslan