Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sign overpunching strictness configurable #491

Closed
yruslan opened this issue Apr 11, 2022 · 0 comments
Closed

Make sign overpunching strictness configurable #491

yruslan opened this issue Apr 11, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@yruslan
Copy link
Collaborator

yruslan commented Apr 11, 2022 •
edited
Loading

Background

Prior 2.4.9 operpunched sign was allowed for unsinged fields as long as the sign is positive.
But sometimes this is a valid encoded number.

Feature

Allow controlling sign overpunch strictness using a flag, say,
.option("strict_sign_overpunching", "true")
@yruslan yruslan added the enhancement New feature or request label Apr 11, 2022
yruslan added a commit that referenced this issue Apr 11, 2022
@yruslan
#491 Make strict sign overpunching configurable.
0ab76c8
yruslan added a commit that referenced this issue Apr 12, 2022
@yruslan
#491 Att a test suite for the configurable sign overpunch strictness.
1d461af
yruslan added a commit that referenced this issue Apr 14, 2022
@yruslan
#491 Make strict sign overpunching the default option.
8504690
yruslan added a commit that referenced this issue Apr 14, 2022
@yruslan
#491 Update README regarding the new feature.
843fca1
yruslan added a commit that referenced this issue Apr 19, 2022
@yruslan
#491 Make strict sign overpunching configurable.
bd804ae
yruslan added a commit that referenced this issue Apr 19, 2022
@yruslan
#491 Att a test suite for the configurable sign overpunch strictness.
ff50a37
yruslan added a commit that referenced this issue Apr 19, 2022
@yruslan
#491 Make strict sign overpunching the default option.
10158f9
yruslan added a commit that referenced this issue Apr 19, 2022
@yruslan
#491 Update README regarding the new feature.
4e1a1a6
@yruslan yruslan closed this as completed Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yruslan