S3Location moved to absa commons #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n commons are released
benedeki
reviewed
Apr 1, 2021
|
|
||
| val location = path.toS3LocationOrFail.withRegion(region) | ||
| val location = path.toS3Location match { |
There was a problem hiding this comment.
Wouldn't the S3Location.apply be easier? No need to match.
There was a problem hiding this comment.
Commons 0.0.27 is now released.
dk1844
force-pushed
the
feature/s3location-in-commons
branch
from
98a09f1
to
02d7c5b
Compare
Zejnilovic
reviewed
Apr 7, 2021
atum/pom.xml
Outdated
| <groupId>za.co.absa.commons</groupId> | ||
| <artifactId>commons_${scala.binary.version}</artifactId> | ||
| <version>${commons.version}</version> | ||
| <scope>provided</scope> |
There was a problem hiding this comment.
Thanks for noticing, my mistake, that was a remnant of an exploratory build. Removed.
Zejnilovic
reviewed
Apr 7, 2021
| <dependency> | ||
| <groupId>za.co.absa.commons</groupId> | ||
| <artifactId>commons_${scala.binary.version}</artifactId> | ||
| <version>${commons.version}</version> |
There was a problem hiding this comment.
Last question. Does this need to be here if there are commons already in atum?
There was a problem hiding this comment.
Regional.scala in this package needs S3Location stuff from Absa commons.
It would work with the dependency on a transitive basis, too (so it would not need to be listed to work), but since we are explicitly using it in this package, we should also explicitly list it, IMHO.
Zejnilovic
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by AbsaOSS/commons#72