Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot add new additionalInfo in metadata #139

Closed
miroslavpojer opened this issue Oct 14, 2022 · 0 comments · Fixed by #140
Closed

Cannot add new additionalInfo in metadata #139

miroslavpojer opened this issue Oct 14, 2022 · 0 comments · Fixed by #140
Assignees
@lsulak @benedeki
Labels
bug Something isn't working

Comments

@miroslavpojer
Copy link
Contributor

Class Accumulator.scala - method setAdditionalInfo

Actual: method calls controlMeasure.setAdditionalInfo(kv, replaceIfExists) and do not save returned instance of controlMeasure
Expected: method saves returned instance of controlMeasure

Missing UT to catch this Bug.
Observed in Enceladus UT: StandardizationExecutionSuite->"StandardizationExecution" should "write dataset properties into info file"
@lsulak lsulak added the bug Something isn't working label Oct 14, 2022
@lsulak lsulak self-assigned this Oct 14, 2022
@benedeki benedeki self-assigned this Oct 14, 2022
benedeki added a commit that referenced this issue Oct 15, 2022
@benedeki
#139: Cannot add new additionalInfo in metadata
0a6cd99
@benedeki benedeki mentioned this issue Oct 15, 2022
Merged
benedeki added a commit that referenced this issue Oct 25, 2022
@benedeki @dk1844
#139: Cannot add new additionalInfo in metadata (#140)
e9f72fd 
* fixes that cannot add new additionalInfo in metadata
* GitHUb Action Spark increased to 3.2.2

Co-authored-by: Daniel Kavan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lsulak lsulak

@benedeki benedeki

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#139: Cannot add new additionalInfo in metadata AbsaOSS/atum
3 participants
@lsulak @benedeki @miroslavpojer