Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make install should install .v files and .glob files in addition to .vo files #526

Closed
JasonGross opened this issue Oct 18, 2024 · 4 comments · Fixed by #529
Closed

make install should install .v files and .glob files in addition to .vo files #526

JasonGross opened this issue Oct 18, 2024 · 4 comments · Fixed by #529

Comments

@JasonGross
Copy link
Contributor

If compcert does not install .v and .glob files, the bug minimizer cannot minimize any bugs in projects that are built on top of compcert.

Note that coq_makefile-made makefiles install the .v and .glob files:
https://github.com/coq/coq/blob/5eedc0b094c7aff4b10e89c547dcb79e1cc672c3/tools/CoqMakefile.in#L396-L401

@JasonGross
Copy link
Contributor Author

I have created #527 for the .v file part. I am not sure how to install the .glob files, as it seems they are not even fully generated by the makefile (different directories overwrite each others' .glob files it seems). Why does compcert invoke -dump-glob explicitly rather than allowing coq to dump the glob file alongside the .v files? This code dates back to the initial git import of compcert.

xavierleroy added a commit that referenced this issue Oct 21, 2024
- Build .glob files in the same directory as the source .v file (Coq default)
- Install .glob files along with .vo and .v files

Fixes: #526
@xavierleroy
Copy link
Contributor

Note that coq_makefile-made makefiles install the .v and .glob files:

I dodn't know about this convention. Flocq doesn't install .glob files, for instance.

I am not sure how to install the .glob files, as it seems they are not even fully generated by the makefile (different directories overwrite each others' .glob files it seems).

I'd be surprised. Some target-dependent modules have multiple implementations in different directories, but only one is compiled.

Why does compcert invoke -dump-glob explicitly rather than allowing coq to dump the glob file alongside the .v files?

A long time ago, .glob files were not generated by default, so an explicit -dump-glob <filename>.glob was needed. Putting the .glob files in a separate directory would reduce clutter. But nowadays this is all moot, esp. since we now have much clutter to begin with (.vok, .vos, .aux, ...).

See #529 for a proposed fix.

@JasonGross
Copy link
Contributor Author

Note that coq_makefile-made makefiles install the .v and .glob files:

I dodn't know about this convention. Flocq doesn't install .glob files, for instance.

Flocq seems to have a separate install-glob target. But indeed the opam package does not install globs, I will prepare a PR

@JasonGross
Copy link
Contributor Author

Some target-dependent modules have multiple implementations in different directories, but only one is compiled.

Ah, I see, that makes sense. I was assuming things based just on the directory structure.

A long time ago, .glob files were not generated by default, so an explicit -dump-glob <filename>.glob was needed. Putting the .glob files in a separate directory would reduce clutter. But nowadays this is all moot, esp. since we now have much clutter to begin with (.vok, .vos, .aux, ...).

Makes sense.

Thanks for fixing so quickly!

See #529 for a proposed fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants