Fix for incorrect vertical offset calculation of suggestion box for flutter mobile web #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrectly on android mobile web. Added new widget tests.
ArticMoon
changed the title
|
So do y'all consider this ready to merged?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
After testing out flutter web app on mobile web on release mode, we saw that the vertical offset of suggestion is not always calculated correctly for the input field. This is specifically the case when suggestion box direction should be up. In other words above the input field. This was also tested when the page is scrollable and the keyboard might be above the field and some cases below the field.
Please Note: New tests were written in separate files for reusability and separation of concern. I have also expanded these tests as some of the test cases were missing.
Feel free to leave comments or any suggestions.
Thanks for your work.
Wilhelm R.