Added direction to allow the list to grow up #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok-- I added some comments -- will take me a while before I can actually test it in my app -- .. would be nice if we had some test stuff here :)
… On Jan 20, 2019, at 11:15 PM, Kenneth Liang ***@***.***> wrote:
@KaYBlitZ <https://github.com/KaYBlitZ> requested your review on: #28 <#28> Added direction to allow the list to grow up.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#28 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB8M7YP-oYfp_16DVqQPjrCPFzq9eq0wks5vFT7OgaJpZM4aKEwe>.
|
sjmcdowall
requested changes
Jan 21, 2019
|
|
||
| OverlayEntry _overlayEntry; | ||
|
|
||
| bool _isOpened = false; | ||
| bool widgetMounted = true; | ||
| double maxHeight = defaultHeight; | ||
|
|
||
| _SuggestionsBoxController(this.context); | ||
| _SuggestionsBoxController(this.context, this.direction); | ||
|
|
||
| open() { | ||
| if (this._isOpened) return; |
There was a problem hiding this comment.
Also the test before (and for some reason I can't comment on that line) in close() could be better done (without the assert) with
this._overlayEntry?.remove();
There was a problem hiding this comment.
Which line is this?
KaYBlitZ
commented
Jan 21, 2019
There was a problem hiding this comment.
I fixed the assert. It should only allow down & up. No left, right, or null. As for the pubspec and the CHANGELOG files, I was looking at the previous commits and Abdul seems to modify these after merging into the develop branch. Then he brings everything back into master.
sjmcdowall
reviewed
Jan 21, 2019
sjmcdowall
approved these changes
Jan 21, 2019
|
Great work @KaYBlitZ! Unfortunately I won't be able to review your work before the weekend, so if you guys are sure if the code you can go ahead and merge it :) |
This was referenced Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the code from yohom and Rassell to create a new attribute direction. This allows the list to grow up or down. It is by default down.
The list will resize to be just below the notch of the device if applicable. It will auto-resize during orientation changes as well.
Let me know what you guys think and see if you can break it ;)