Final #26
Final #26
Conversation
Functionalities
There was a problem hiding this comment.
Hi @AbdifatahYasin1,
Good job so far! 🔥
You still need to work on some issues to prepare your project for the final evaluation, but you are almost there!
Suggested changes ♻
Check the comments under the review.
Please feel free to use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you take them into account as they can make your code better._
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
package.json
Outdated
| "devDependencies": { | ||
| "babel-eslint": "^10.1.0", | ||
| "eslint": "^7.32.0", | ||
| "eslint-config-airbnb-base": "^14.2.1", | ||
| "eslint-plugin-import": "^2.27.4", | ||
| "stylelint": "^13.13.1", | ||
| "stylelint-config-standard": "^21.0.0", | ||
| "stylelint-scss": "^3.21.0", | ||
| "webpack": "^5.75.0", | ||
| "webpack-cli": "^5.0.1" |
There was a problem hiding this comment.
- It would be good to add all the necessary dependencies to run the app. We actually need the webpack dev server and it is missing here.
- Let's add this line in
devDependencies
"webpack-dev-server": "^4.11.1"
package.json
Outdated
| "dependencies": { | ||
| "html-webpack-plugin": "^5.5.0", | ||
| "jest": "^29.3.1" | ||
| }, |
There was a problem hiding this comment.
- As mentioned above all necessary dependencies are required in the package.json, which will help install everything needed when setting up the app with the
npm installcommand
- Let's add these lines in
dependencies
"css-loader": "^6.7.3",
"style-loader": "^3.3.1"|
|
||
| describe('Comments Length', () => { | ||
| test('Counts the number of comments in array', () => { | ||
| expect(displayCommentsCounter(comments)).toBe(5); | ||
| }); | ||
|
|
||
| test('Counts the number of comments in array', () => { | ||
| expect(displayCommentsCounter(comments)).not.toBe(6); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
- The tests are not running are expected, we still have a dependency issue. As mentioned above, let's add it
- Let's add this line in
devDependencies
"@babel/preset-env": "^7.20.2",
There was a problem hiding this comment.
Hi @AbdifatahYasin1,
In my opinion, your project is ready for presentation! ⚡🔥 There is nothing else to say other than... it's time to merge it 
Good luck! 🎉
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
This project is about meal web API . it has like and comment features.