-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.env override for docker-compose.yml #481
.env override for docker-compose.yml #481
Conversation
Oh, the draft wasn't supposed to start your Actions, sorry. Hope it's free |
Thank you. Most of the stuff could actually be configured with There is a discussion for the overriding the ports, because this is not possible per default. #430 I would prefer to keep the changes limited to the port, with one value for all UIs. Maybe we need to have a consistent prefix for the variable, something like
Oh yeah it is all free! |
Thanks, didn't see the discussion. Will continue there. You can close or use this PR if you want. |
Thank you! I think it's better to add |
I have added a minimal solution #521, which should be enough, I don't believe we need a high level of very granular customizability through the env file, a docker compose override should help you get most of the way there. |
I had it like that at first, but when services change you would have to keep track of the names. Right now you can have multiple
I use that for switching between profiles with my custom settings. I don't have the resources to run multiple profiles at the same time so I did not test that use case.
That's an OK solution for now, removing the multiple port problem. Good enough for my use cases. 👍 Let's just hope docker compose gets a patch to make the override more useful. The latest release does not seem to do what we need: #430 (reply in thread) |
I will close this PR now, thank you for contributing, if we want to add this in the future I will reach out to you again. |
What do you think of this?
docker-override.yml
, it for instance binds ports from both ymlsExample:
"${HOST_PORT:-7860}:7860"
- setting indocker-compose.yml
HOST_PORT=12345
- override in.env