-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commands #59
Add commands #59
Conversation
def apply(self, *args: str) -> None: | ||
pass | ||
|
||
# TODO: make more robust way to specify arguments for commands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted some outside input on this, but other than this this PR should be good to merge. I have a few ideas for how we could do arguments that I think could be better; for one, we could have an 'argumentvalidator' thing that not only would make it easier to print the argument names (i.e., it could put different brackets around required and optional arguments, as well as including defaults, etc.) but it would also let us print a usage of the command if it's misused. I also think it would be a lot better to include the command arguments in the command initialization (rather than the apply function). Let me know your thoughts on it all!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets have a call and maybe you can walk me through this
942b757
to
ea79a6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff! This is a big step up in functionality we'll be able to have.
I've left some comments, I still need to better understand the prompt_toolkit stuff
def apply(self, *args: str) -> None: | ||
pass | ||
|
||
# TODO: make more robust way to specify arguments for commands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets have a call and maybe you can walk me through this
5b3295f
to
eef7f15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
No description provided.