Use custom exceptions instead of KeyboardInterrupts and exit() #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PCSwingle
reviewed
Aug 2, 2023
mentat/code_file_manager.py
Outdated
| @@ -137,7 +134,7 @@ def _set_file_paths( | |||
| cprint("The following paths do not exist:") | |||
| print("\n".join(invalid_paths)) | |||
| print("Exiting...") | |||
| exit() | |||
| raise UserError() | |||
There was a problem hiding this comment.
We could change the error to be the following paths don't exist instead of cprinting, and maybe get rid of the 'exiting...'? Since that should be standard (either always have it, or always don't have it).
There was a problem hiding this comment.
It turns out the warning for bad file paths got broken when we switched to globbing so I moved this chunk of code to expand_paths() in app.py.
PCSwingle
reviewed
Aug 2, 2023
mentat/code_file_manager.py
Outdated
| @@ -249,7 +246,7 @@ def _get_new_code_lines(self, changes) -> Iterable[str]: | |||
| min_changed_line = largest_changed_line + 1 | |||
| for i, change in enumerate(changes): | |||
| if change.last_changed_line >= min_changed_line: | |||
| raise ValueError(f"Change line number overlap in file {change.file}") | |||
| raise UserError(f"Change line number overlap in file {change.file}") | |||
There was a problem hiding this comment.
This should be a MentatError; the collision handling is supposed to handle this
PCSwingle
reviewed
Aug 2, 2023
| @@ -24,12 +25,10 @@ def setup_api_key(): | |||
| openai.api_key = key | |||
| openai.Model.list() # Test the API key | |||
| except openai.error.AuthenticationError: | |||
| cprint( | |||
| raise UserError( | |||
There was a problem hiding this comment.
We call this function before the try except in app.py; we should move that call into loop() so this error gets properly caught
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't raise KeyboardInterrupts. Also raise exceptions instead of exit() so we can print the final cost.