Check early if file tokens exceed or near limit #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PCSwingle
reviewed
Aug 2, 2023
mentat/app.py
Outdated
| @@ -57,7 +57,7 @@ def run(paths: Iterable[str], exclude_paths: Optional[Iterable[str]] = None): | |||
| try: | |||
| loop(paths, exclude_paths, cost_tracker) | |||
| except (EOFError, KeyboardInterrupt) as e: | |||
| print(e) | |||
| cprint("\n" + str(e), color="red") | |||
There was a problem hiding this comment.
? Why is this here? All it does for me is print a lot of newlines
There was a problem hiding this comment.
If the error has a message (like the new ones I introduced) then it prints it here - you shouldn't be getting more than 2 new lines even if there error has no message, right?
The "\n" is there to separate the error from the file tree
There was a problem hiding this comment.
But the error is EOF or KeyboardInterrupt; why would it have a message?
|
I just realized we need to take into account the prompt tokens when doing this check, I'll update before merging |
PCSwingle
force-pushed
the
early-token-check
branch
from
289f8c5
to
c6db6ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.