-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo undo printing #372
Redo undo printing #372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
actually should we display the inverse of the changes? I'm not sure what would be clearer... |
I think it makes sense the way it currently is, but I definitely see both sides. |
I too think red makes sense. Maybe a simple 'inverse' arg somewhere could make this simple. |
Maybe we could keep the edit the same but surround it with something to make it more clear it's being undone? Or indent the whole block with some prefix for all the lines to show it's an undo? |
I prefer this approach a lot; what are your thoughts for how we would make it clearer though? |
Thoughts?
|
Oh, I like this a lot! I'll get this done and then merge. |
Fixes #356.