Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pre tags so whitespace isnt collapsed #344

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

PCSwingle
Copy link
Member

@PCSwingle PCSwingle commented Dec 1, 2023

Fixed #342. Use <pre> tags to display text so whitespace appears normally; this always means we don't need to replace newlines with <br> tags.

@jakethekoenig
Copy link
Member

I liked it more the other way. This way paragraphs are all on one line and you have to do a lot of side scrolling.

@PCSwingle
Copy link
Member Author

Oh hmm, I do want it to still wrap. I think there is a way to make it still wrap (as long as there's a breaking character); let me fix that. I do think we definitely want this though, since seeing the whitespace is important (otherwise it could be easy to miss a bug relating to whitespace)

@granawkins
Copy link
Member

granawkins commented Dec 2, 2023

EDIT: When I use the --diff command...

I'm getting these errors from the conversation_viewer when I click on a message to see context. It only happens on this branch but I can't see how it's related. Anyone else get this?

image

@PCSwingle
Copy link
Member Author

@granawkins could you send me the exact transcript that happens on? I'm not getting this error

Copy link
Member

@jakethekoenig jakethekoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the wrap! Looks good to me. I can't imagine Grant's error is related though we should get to the bottom of it.

@granawkins
Copy link
Member

I think the problem is related to the size of the diff - I was using a massive one, but a smaller one works fine. Good to go!

@PCSwingle PCSwingle merged commit 1f21444 into main Dec 5, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whitespace in conversation viewer
3 participants