Remove git root from CodeFileManager, FileEdit #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constructors
TerminalClient constructors
granawkins
requested changes
Nov 13, 2023
PCSwingle
reviewed
Nov 13, 2023
PCSwingle
reviewed
Nov 13, 2023
CodeFileManager and FileEdit
granawkins
approved these changes
Nov 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
git_rootfromCodeFileManagerandFileEdit, makingSESSION_CONTEXT.cwdthe root path to join any relative file paths to.FileEdit.file_pathis now validated during instantiation. The value must be aPathtype and must be absolute.CodeFileManager.file_linesnow expects all keys to be absolute paths instead of relative paths.This PR is part of a series of PRs to remove
git_rootfrom Mentat, and allow Sessions to be run anywhere on the filesystem.