Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation viewer #152

Merged
merged 10 commits into from
Oct 17, 2023
Merged

Conversation viewer #152

merged 10 commits into from
Oct 17, 2023

Conversation

PCSwingle
Copy link
Member

@PCSwingle PCSwingle commented Oct 13, 2023

TODO:

Increase aesthetic appeal
Should we make conversation command hidden? It probably isn't too useful to the average viewer, and it looks very hacked together

@PCSwingle
Copy link
Member Author

PCSwingle commented Oct 13, 2023

Current state screenshot:

EDIT: It has changed quite a bit since this

image

@PCSwingle
Copy link
Member Author

Just uploaded a transcript with a fairly large conversation; feel free to use the transcript viewer to check it out!

transcript_20231013_144235.log

@PCSwingle PCSwingle marked this pull request as ready for review October 16, 2023 21:44
@PCSwingle PCSwingle mentioned this pull request Oct 17, 2023
Copy link
Member

@jakethekoenig jakethekoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you say hide /conversation you mean remove it from the autocompleter? I think that'd be a good idea. I also like the idea of using jinja for our templates. I think it's good enough to merge though. One feature requests going forward: It'd be really nice if transcript_viewer could automatically open the most recent transcript and if you could scroll through them with the arrow keys.

@@ -35,8 +44,12 @@ def __init__(self):
self.model = config.model()
self.messages = list[dict[str, str]]()

# This contain the messages the user actually sends and the messages the model output
# along with a snapshot of exactly what the modelg got before that message
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/modelg/model/g


CONVERSATION: ContextVar[Conversation] = ContextVar("mentat:conversation")


class MessageRole(Enum):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to call this Role. Thanks for refactoring it in this way. I think it's a bit cleaner.

@PCSwingle
Copy link
Member Author

PCSwingle commented Oct 17, 2023

When you say hide /conversation you mean remove it from the autocompleter? I think that'd be a good idea. I also like the idea of using jinja for our templates. I think it's good enough to merge though. One feature requests going forward: It'd be really nice if transcript_viewer could automatically open the most recent transcript and if you could scroll through them with the arrow keys.

Oohh, I really like that idea of being able to scroll through them. I'll add an issue for both jinja and the transcript scrolling, since it'll be a lot easier to implement the scrolling once we have jinja

@PCSwingle PCSwingle merged commit 0765ceb into main Oct 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants