-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation viewer #152
Conversation viewer #152
Conversation
Just uploaded a transcript with a fairly large conversation; feel free to use the transcript viewer to check it out! |
74df13d
to
48dacc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you say hide /conversation
you mean remove it from the autocompleter? I think that'd be a good idea. I also like the idea of using jinja for our templates. I think it's good enough to merge though. One feature requests going forward: It'd be really nice if transcript_viewer
could automatically open the most recent transcript and if you could scroll through them with the arrow keys.
mentat/conversation.py
Outdated
@@ -35,8 +44,12 @@ def __init__(self): | |||
self.model = config.model() | |||
self.messages = list[dict[str, str]]() | |||
|
|||
# This contain the messages the user actually sends and the messages the model output | |||
# along with a snapshot of exactly what the modelg got before that message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/modelg/model/g
|
||
CONVERSATION: ContextVar[Conversation] = ContextVar("mentat:conversation") | ||
|
||
|
||
class MessageRole(Enum): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to call this Role
. Thanks for refactoring it in this way. I think it's a bit cleaner.
Oohh, I really like that idea of being able to scroll through them. I'll add an issue for both jinja and the transcript scrolling, since it'll be a lot easier to implement the scrolling once we have jinja |
TODO:
Increase aesthetic appeal
Should we make conversation command hidden? It probably isn't too useful to the average viewer, and it looks very hacked together