-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specialized parsing functions for portable pdb blobs #38
Merged
jkoritzinsky
merged 14 commits into
AaronRobinsonMSFT:master
from
jkoritzinsky:ppdb-blobs
Aug 30, 2023
Merged
Add specialized parsing functions for portable pdb blobs #38
jkoritzinsky
merged 14 commits into
AaronRobinsonMSFT:master
from
jkoritzinsky:ppdb-blobs
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. We aren't going to do any CustomDebugInformation structures as they're language/compiler specific, annoying, and not all documented in the Portable PDB spec.
AaronRobinsonMSFT
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this work, I also added a separate target for referencing a version of DNMD with portable PDB support enabled (exported as dnmd::pdb).
This implements all of the blob formats specified in the Portable PDB Spec 1.0 not in the CustomDebugInformation section.
Fixes #36 as much as we plan to.
This should also get us to feature parity with https://github.com/AaronRobinsonMSFT/PPDB