-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fill configs and write to disk on load #438
feat: fill configs and write to disk on load #438
Conversation
Looks like your PR modifies shared library files in We highly recommend getting your code reviewed by one of the core maintainers to avoid breaking other projects that depend on these files :-) |
Breaking because of unknown issue with @KennethEnevoldsen, do you have experience here? ❤️ |
I would run the debugger and check what the type actually is. Btw. the issue on confection is quite hard to follow. I would create a minimal example. |
The type is a dict shaped like:
Looking into writing a minimal reproducible example now. |
Updated the Confection issue with an example :-) |
Hmm odd. You can naturally turn off the type-checking (validate=False). Seem like confection resolved in during filling. However, it seems like it shouldn't be an error as it simply resolve it correctly. Might be that there is a bug in either the config or the resolving. |
…to-update-defaults-in-cfg-from-defaults-in-function-signatures
Yeah, that succeeds on filling, but removes the |
Added a few additional stuff to the other issues. It seems like it might be a bug. |
This PR is stale because it has been open 1+ days with no activity. Feel free to either 1) remove the stale label or 2) comment. If nothing happens, this will be closed in 7 days. |
I'll close this for now. We can track it in #426. |
This PR is stale because it has been open 1+ days with no activity. Feel free to either 1) remove the stale label or 2) comment. If nothing happens, this will be closed in 7 days. |
No description provided.