Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Firebase Integration for Push Notification #2692

Merged
merged 78 commits into from
Jan 19, 2025
Merged

[Feature]: Firebase Integration for Push Notification #2692

merged 78 commits into from
Jan 19, 2025

Conversation

Ayush8923
Copy link
Contributor

@Ayush8923 Ayush8923 commented Nov 29, 2024 •
edited
Loading

closes: #2662

Changes

  • Integrate the Firebase Cloud Messaging for web push notifications.

@Ayush8923 Ayush8923 self-assigned this Nov 29, 2024
Ayush8923
Ayush8923 commented Dec 2, 2024
View reviewed changes
src/app/app.component.html Outdated Show resolved Hide resolved
Ayush8923
Ayush8923 commented Dec 3, 2024
View reviewed changes
src/app/app.component.ts Outdated Show resolved Hide resolved
@sleidig sleidig changed the base branch from master to feat/1055_notifications-final December 13, 2024 15:22
@Ayush8923 Ayush8923 requested a review from sleidig December 17, 2024 05:28
@Ayush8923 Ayush8923 marked this pull request as ready for review December 17, 2024 05:28
@sleidig sleidig requested a review from tomwwinter December 23, 2024 15:42
Ayush8923 and others added 13 commits December 25, 2024 17:08
fix(*): import the mocked testing module in notification spec file
4302bd3
fix(*): update the fireabse integration test cases
ae02f69
fix(*): revert the spec file changes
c80907a
@Ayush8923
Merge branch 'feat/1055_notifications-final' into feat/push-notificat…
fb58ff5 
…ion-firebase-integration
fix(*): update the device notification api enpoint
e45eafe
@Ayush8923
Merge branch 'feat/1055_notifications-final' into feat/push-notificat…
f268d14 
…ion-firebase-integration
@Ayush8923
Merge branch 'feat/1055_notifications-final' into feat/push-notificat…
b179bcf 
…ion-firebase-integration
fix(*): added the test trigger button
aaf5624
Merge branch 'feat/push-notification-firebase-integration' of https:/…
9bbda77 
…/github.com/Aam-Digital/ndb-core into feat/push-notification-firebase-integration
fix: linting fixes
3e7b3ab
feat: implement the logic to update the token and save the token in b…
c265e54 
…ackend & update the test cases
fix: refactoring the api logic
1f79ca6
fix: update the test cases
6437248
@Ayush8923
Copy link
Contributor Author

@tomwwinter I have implemented the notification token logic and test notification logic in this PR. Can you please review this PR and let me know if there are any updates needed? The Save Notification Token API is working correctly. However, when trying to trigger the Test Notification API, I encounter a 500 Internal Server Error. I think something is breaking on the backend side.

image

tomwwinter
tomwwinter approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@tomwwinter tomwwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved after refactoring

@tomwwinter tomwwinter merged commit 51d78ef into feat/1055_notifications-final Jan 19, 2025
12 checks passed
@tomwwinter tomwwinter deleted the feat/push-notification-firebase-integration branch January 19, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleidig sleidig sleidig left review comments

@tomwwinter tomwwinter tomwwinter approved these changes

Assignees

@Ayush8923 Ayush8923

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Receive push notification without opening the app
3 participants
@Ayush8923 @sleidig @tomwwinter