Frontend adaptions for user permissions #1036
Conversation
There was a problem hiding this comment.
New changes look good. Thanks for the further code (and especially test) cleanups 😊
The small issue with local session mode seems at least less severe for me at the moment:
- creating local demo data with "demo" login
- logging out and logging in as "demo-admin"
- (!) immediately after login I get a "demo-admin" entity not found warning in console on list views, this does resolve after some waiting/navigating however and all other data seems fine
I assume the "migration" from one local user db to the other does not block login and may just take a second until the user object (and other data) is available.
We can't support continuous updates between various users in local mode, can we? As this is just developer mode I wouldn't invest time on it at the moment, though.
Good to go in my eyes!
Co-authored-by: Sebastian <[email protected]>
# Conflicts: # src/app/child-dev-project/attendance/activity-attendance-section/activity-attendance-section.component.spec.ts # src/app/child-dev-project/attendance/activity-attendance-section/activity-attendance-section.stories.ts # src/app/child-dev-project/notes/note-details/note-details.component.html # src/app/core/database/pouch-database.spec.ts # src/app/core/database/pouch-database.ts # src/app/core/demo-data/demo-data.service.ts # src/app/core/entity-components/entity-form/entity-form.service.spec.ts # src/app/features/historical-data/historical-data/historical-data.stories.ts # src/app/utils/di-tokens.ts
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 3.4.0-master.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
see issue: #769
Visible/Frontend Changes
--
Architectural/Backend Changes