Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync does not work after user is inactive for some time #935

Closed
sleidig opened this issue Aug 3, 2021 · 5 comments · Fixed by #2312
Closed

Sync does not work after user is inactive for some time #935

sleidig opened this issue Aug 3, 2021 · 5 comments · Fixed by #2312
Assignees
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Status: Complex Issue advanced, particularly challenging topic that requires extensive knowledge of the code base Type: Bug

Comments

@sleidig
Copy link
Member

sleidig commented Aug 3, 2021

Describe the bug
The remote authentication is not refreshed automatically so if a user is not making changes for 10 minutes, the remote session expires. Any local changes after that are not synced (Network tab of developer console will show a 401 response).

To Reproduce
Steps to reproduce the behavior:

  1. Log in
  2. Edit an entity --> changes are synced as expected
  3. Wait 10 minutes
  4. Edit another entity --> changes are not synced to server, request receives 401

Expected behavior
As long as the user is logged in the frontend, the remote auth should be automatically kept alive so that syncing always works.

@sleidig sleidig changed the title Sync 401 after user is inactive for some time Sync does not work after user is inactive for some time Aug 3, 2021
@TheSlimvReal TheSlimvReal self-assigned this Sep 8, 2021
@TheSlimvReal
Copy link
Collaborator

with #956 this will be somewhat fixes by our own auth implementation (logged in for 2h, for each requests during that time the two hours start again). What is missing is a frontend feedback when the auth-cookie is expired. In this case the user should be logged out.

@TheSlimvReal
Copy link
Collaborator

TheSlimvReal commented Jul 5, 2022

One option could be to automatically logout the user if the cookie expires / requests of the PouchDB are returning 401. This should not restrict the offline capability though.

@sleidig sleidig mentioned this issue Aug 24, 2023
3 tasks
@sleidig sleidig moved this from Triage to Priority (Core Team) in All Tasks & Issues Aug 24, 2023
@sleidig
Copy link
Member Author

sleidig commented Jan 26, 2024

also see related #2044

@sleidig sleidig moved this from Priority (Core Team) to Todo [help wanted] in All Tasks & Issues Feb 6, 2024
@sleidig sleidig added the Status: Complex Issue advanced, particularly challenging topic that requires extensive knowledge of the code base label Feb 6, 2024
@sleidig sleidig moved this from Todo (ready for work) to Triage / Analysis in All Tasks & Issues Mar 19, 2024
sleidig added a commit that referenced this issue Mar 20, 2024
for better error handling
also prevents aborted sync after expired access token

closes #2100, closes #935
@sleidig sleidig self-assigned this Mar 20, 2024
@sleidig sleidig moved this from Triage / Analysis to In Review in All Tasks & Issues Mar 20, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in All Tasks & Issues Mar 22, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.34.0-master.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Mar 22, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.34.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Status: Complex Issue advanced, particularly challenging topic that requires extensive knowledge of the code base Type: Bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants