Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup Wizard: Configure Validators for fields #2118

Closed
4 tasks
sleidig opened this issue Dec 4, 2023 · 2 comments · Fixed by #2345
Closed
4 tasks

Setup Wizard: Configure Validators for fields #2118

sleidig opened this issue Dec 4, 2023 · 2 comments · Fixed by #2345
Assignees
@Abhinegi2
Labels
Client: by X released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Feature new user-facing feature
Milestone
Setup Wizard

Comments

@sleidig
Copy link
Member

sleidig commented Dec 4, 2023 •
edited
Loading

sub-task of #2047 , #2057

Allow users to configure "validators" for individual fields of an entity in the field-config popup, like setting a field as "required".

Implementation steps

  • extend existing UI component from PR Basic Setup Wizard / Admin UI #2057 (AdminEntityFieldComponent), create and include a new component to be shown in the "Advanced Options & Validation" tab
    • that component should display a form which will configure a FormValidatorConfig within the EntitySchemaField interface
    • should allow to add one or more validators from a list of available
  • transform DynamicValidatorsService hard-coded list of validators into a more specified interface for validators
  • use the array of DynamicValidatorsService to dynamically display all available validators in the form
  • add field to configure a validator, when required (e.g. defining the number for a "min" or "max" validator through a form field)

possible UI draft (suggestion):
image
@sleidig sleidig added the Type: Feature new user-facing feature label Dec 4, 2023
@sleidig sleidig added this to the Setup Wizard milestone Dec 4, 2023
@sleidig sleidig mentioned this issue Dec 4, 2023
Merged
29 tasks
@sleidig sleidig moved this from Triage / Analysis to Todo (ready for work) in All Tasks & Issues Mar 5, 2024
@sleidig sleidig moved this from Todo (ready for work) to Planned (current "sprint") in All Tasks & Issues Apr 17, 2024
@sleidig sleidig moved this from Planned (current "sprint") to In Progress in All Tasks & Issues Apr 17, 2024
@Abhinegi2 Abhinegi2 mentioned this issue Apr 18, 2024
Merged
2 tasks
@sleidig sleidig moved this from In Progress to In Review in All Tasks & Issues Apr 23, 2024
sleidig added a commit that referenced this issue Apr 23, 2024
@Abhinegi2 @sleidig
feat(Admin UI): configure validators like "required" for fields (#2345)
d784a79 
closes #2118 

---------

Co-authored-by: Sebastian Leidig <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Done in All Tasks & Issues Apr 23, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.35.0-master.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Apr 23, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abhinegi2 Abhinegi2

Labels
Client: by X released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Feature new user-facing feature
Projects
All Tasks & Issues
Archived in project
Milestone
Setup Wizard
Development

Successfully merging a pull request may close this issue.

Setup Wizard: Configure Validators for fields Aam-Digital/ndb-core
3 participants
@sleidig @aam-digital-ci @Abhinegi2