Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Logging Support #280

Merged
merged 3 commits into from
Nov 11, 2019
Merged

Add Logging Support #280

merged 3 commits into from
Nov 11, 2019

Conversation

tatayu
Copy link

@tatayu tatayu commented Nov 11, 2019

New

  • Added logging support for Dolla.
  • The logging messages will be saved in the data folder (data/dollaLogger.log).
  • New log messages will be appended to the log file instead of overwriting it.
  • Currently included the exceptions in Storage and Parser.

Weng-Kexin
Weng-Kexin reviewed Nov 11, 2019
View reviewed changes
Copy link

@Weng-Kexin Weng-Kexin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@Weng-Kexin Weng-Kexin merged commit d50cbb6 into AY1920S1-CS2113T-F11-2:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omupenguin omupenguin omupenguin approved these changes

@yetong1895 yetong1895 yetong1895 approved these changes

@Weng-Kexin Weng-Kexin Weng-Kexin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tatayu @Weng-Kexin @yetong1895 @omupenguin