fix: (hack) Ensure vizinterface knows about RWModels enum.

[dpad]

• Tickets addressed:
• Review: By file
• Merge strategy: Merge (no squash)

Description

Work-around to fix a minor issue when trying to read the RWModel value of RWConfigLogMsgPayloads when vizInterface is also available. Here, Python would interpret RWConfigLogMsgPayloads as actually coming from the vizinterface module. However, the vizinterface module was not aware of the "RWModels" enum, so SWIG did not know how to interpret it as an integer, nor how to destroy it (leading to some "detected a memory leak of type 'RWModels *'" warnings). With this fix, RWModels correctly returns an integer, and the warning disappears.

NOTE: This is not a proper fix, but only works around the issue in the same way we've been doing before. We should really tackle the root cause at some point.

Root cause: This kind of issue is also present in other types, e.g. SysModel, seemingly because of how we're copying SWIG types across many modules. For example, the SysModel definition re-appears in each individual message module. Fixing this (e.g. such that SysModel is only defined in one module) would probably significantly reduce the size of the total compiled Basilisk.

Verification

I don't really have a minimal way to test this, but basically, when getting the value of a RWConfigLogMsgPayload's .RWModel, it was returning a Swig Object of type 'RWModels *' instead of an integer. After this fix, it correctly returns an integer.

Documentation

Future work

[schaubh]

Thanks for the fix. The pre-commit CI test failed due to trailing white space in some files. I fixed that and pushed a revised version.