Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conan profile configuration doesn't work at first #525

Closed
sassy-asjp opened this issue Dec 6, 2023 · 0 comments · Fixed by #737
Closed

Conan profile configuration doesn't work at first #525

sassy-asjp opened this issue Dec 6, 2023 · 0 comments · Fixed by #737

Comments

@sassy-asjp
Copy link
Contributor

Describe the bug
As noted in #523, the conanfile.py tries to run some configuration steps, but it doesn't actually work as intended. It will work on subsequent runs since conan is already configured, however for the first run, the updated configuration doesn't get loaded properly.

To reproduce
Steps to reproduce the behavior:

  1. From a new Linux user account (or delete your account's ~/.conan)
  2. Follow the instructions to build Basilisk
  3. Some features such as vizInterface will not work due to ABI incompatibility

Expected behavior
The build to work properly the first time

Desktop (please complete the following information):

  • OS: Linux
  • Version Ubuntu 22.04.3 LTS
  • Python version 3.11.6

Additional context
The easiest method is to have the user configure the conan settings before building Basilisk instead of configuring it inside the conanfile.

conan profile new default --detect
conan profile update settings.compiler.libcxx=libstdc++11 default # only on Linux

This would also avoid mangling the user's default conan profile if the user wants to use it for something else. It may also be good to allow the user to easily specify what conan profile to use.

dpad added a commit to dpad/basilisk that referenced this issue Jun 27, 2024
dpad added a commit to dpad/basilisk that referenced this issue Jun 27, 2024
dpad added a commit to dpad/basilisk that referenced this issue Jun 27, 2024
dpad added a commit to dpad/basilisk that referenced this issue Jun 28, 2024
dpad added a commit to dpad/basilisk that referenced this issue Jul 19, 2024
dpad added a commit to dpad/basilisk that referenced this issue Jul 26, 2024
schaubh pushed a commit that referenced this issue Jul 30, 2024
schaubh pushed a commit that referenced this issue Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant