fix [Bug]: Extension update check issue #6447 #8245
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this pull request is trying to achieve.
One line patch to fix a bug that has recurred: Extension update check issue #6447
Additional notes and description of your changes
This code:
repo.remote().fetch("--dry-run")
produces this git command:
git fetch -v -- origin --dry-run
Gives an error:
fatal: couldn't find remote ref --dry-run
The corrected code:
repo.remote().fetch(dry_run=True)
produces this git command:
git fetch -v --dry-run -- origin
Which does not cause an error.
This seems to be due to a change in GitPython 3.1.31 vs 3.1.27, but the correction using a kwarg is a better way to do it I guess.
We can reproduce the bug outside the webui, like this:
Old code, causes an error:
New code, no error:
Showing that kwarg options are passed through to the git command line:
Environment this was tested in
List the environment you have developed / tested this on. As per the contributing page, changes should be able to work on Windows out of the box.
I also tested it with the older GitPython that is specified in requirements_versions.txt:
I didn't test it on Windows, but I don't think that it can break anything on Windows.