Fix broken image downscale TypeError #7945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fx broken image downscale caused by reword settings for 4chan export, remove unneded try/excepts, add try/except for actually saving JPG which also remove the float to int casting of
opts.target_side_length
as resize size can only be integer tuple this raises an error causing the downscale to fail
This PR fixes the issue
yes I could just typed casted as I did before
but since I'm bored I used round() for more accurate approximation
note: the round() functions will returns int type
Return number rounded to ndigits precision after the decimal point. If ndigits is omitted or is None, it returns the nearest integer to its input.
why also use round() on
opts.target_side_length
and not int()?for those thick headed people that decides to use a non integer value