Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix upscaler 2 images do not match #15425

Conversation

light-and-ray
Copy link
Contributor

@light-and-ray light-and-ray commented Apr 1, 2024

Description

I had a dream there can be a bug when the first upscaler rounds size to 8, and second upscaler doesn't because it's non-ai. But foutunatley it's okay, every upscaler rounds size to 8. (E.g. 1023 -> 1016) But due to this I've found another bug:

  1. Set first upscaler AI
  2. Set second upscaler lanczos
  3.     return im1._new(core.blend(im1.im, im2.im, alpha))
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     ValueError: images do not match
    

It happens because of different image modes

Also I've added minimum=0 and step=8 in mix_side_length, but it affects only on arrows next to number input

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit 7192961 into AUTOMATIC1111:dev Apr 1, 2024
2 of 3 checks passed
@light-and-ray light-and-ray deleted the fix_upscaler_2_images_do_not_match branch April 1, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants