Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move upscale postprocessing under input accordion #15223

Conversation

light-and-ray
Copy link
Contributor

@light-and-ray light-and-ray commented Mar 11, 2024

Description

Move upscaler script in extras under input accordion. It's opened and enabled by default

Why I've made this:

  • Upscaler 2 dropdown was at the same level with GFPGAN accordion
  • Scale by / Scale to tabs section looked detached form the other options. I often loose it from my view
  • to unify visual with other scripts

I've swapped scale row and upscalers rows for 2 reasons:

  • Move "heavier" element to the bottom
  • Repeat pattern from Hires. fix InputAccordion where Upscaler dropdown is upper then scale sliders

It's opened and enabled by default because:

  • it's main feature of extras tab
  • it preserves the previous behavior
  • if user hasn't overridden default upscaler, they can not close and disable it because of None default upscalers. (The minimal number of clicks)

I've chosen InputAccordion to allow user change default upscaler, and simple disable upscaling script if they doesn't want to use it

Screenshots/videos:

Before:
Screenshot 2024-03-12 at 02-06-50 Stable Diffusion

After:
Screenshot 2024-03-12 at 02-12-18 Stable Diffusion

Checklist:

@w-e-w
Copy link
Collaborator

w-e-w commented Mar 11, 2024

second this
I've been meaning to do this myself but just never got around doing it

@AUTOMATIC1111 AUTOMATIC1111 merged commit 2fc47b4 into AUTOMATIC1111:dev Mar 16, 2024
3 checks passed
@light-and-ray light-and-ray deleted the move_upscale_postprocessing_under_input_accordion branch March 16, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants