Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove taming_transformers dependency #10856

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

akx
Copy link
Collaborator

@akx akx commented May 30, 2023

Description

I noticed that the taming_transformers repository takes 2.5 minutes to clone (history and all 😩) and is hueg liek xbox pretty big on disk:

$ du -hs repositories/taming-transformers/
566M	repositories/taming-transformers/

and we only ever used a single class from a single module therein, so why not just yeet the whole thing and vendor in that single module?

Of course there might be something I don't know, but this seems pretty straightforward...

Checklist:

…ing_transformers dependency

(and fix the two ruff complaints)
@akx akx marked this pull request as ready for review May 30, 2023 09:49
@akx akx requested a review from AUTOMATIC1111 as a code owner May 30, 2023 09:49
@AUTOMATIC1111 AUTOMATIC1111 merged commit 0b0f60f into AUTOMATIC1111:dev May 31, 2023
@AUTOMATIC1111
Copy link
Owner

that's a bold move

@akx
Copy link
Collaborator Author

akx commented May 31, 2023

that's a bold move

let's see if it pays off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants