Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cataclysm] AllTheThings/src/Classes/Item.Classic.lua:70: bad argument #1 to 'ipairs' (table expected, got number) #1833

Closed
ThaDanus opened this issue Nov 4, 2024 · 6 comments

Comments

@ThaDanus
Copy link

ThaDanus commented Nov 4, 2024

Game Flavor (please complete the following information):

  • Flavor: Cataclysm

Describe the bug
After upgrading to version 4.1.4a just now, upon logging into the game, I get this error:

Message: ...ace/AddOns/AllTheThings/src/Classes/Item.Classic.lua:70: bad argument #1 to 'ipairs' (table expected, got number)
Time: Mon Nov  4 19:17:15 2024
Count: 1
Stack: ...ace/AddOns/AllTheThings/src/Classes/Item.Classic.lua:70: bad argument #1 to 'ipairs' (table expected, got number)
[string "=[C]"]: ?
[string "@Interface/AddOns/AllTheThings/src/Classes/Item.Classic.lua"]:70: in function <...ace/AddOns/AllTheThings/src/Classes/Item.Classic.lua:56>
[string "=(tail call)"]: ?
[string "@Interface/AddOns/AllTheThings/src/Classes/Item.Classic.lua"]:186: in function <...ace/AddOns/AllTheThings/src/Classes/Item.Classic.lua:185>
[string "=(tail call)"]: ?
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:70: in function <.../AddOns/AllTheThings/src/UI/Classic Window Logic.lua:29>
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:120: in function <.../AddOns/AllTheThings/src/UI/Classic Window Logic.lua:103>
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:48: in function <.../AddOns/AllTheThings/src/UI/Classic Window Logic.lua:29>
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:120: in function <.../AddOns/AllTheThings/src/UI/Classic Window Logic.lua:103>
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:48: in function <.../AddOns/AllTheThings/src/UI/Classic Window Logic.lua:29>
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:120: in function <.../AddOns/AllTheThings/src/UI/Classic Window Logic.lua:103>
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:48: in function <.../AddOns/AllTheThings/src/UI/Classic Window Logic.lua:29>
...
[string "@Interface/AddOns/AllTheThings/src/UI/Windows/Prime.lua"]:50: in function <...terface/AddOns/AllTheThings/src/UI/Windows/Prime.lua:49>
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:1762: in function `ForceUpdate'
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:1683: in function `ForceRebuild'
[string "@Interface/AddOns/AllTheThings/src/UI/Windows/Prime.lua"]:41: in function `OnLoad'
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:1582: in function `Load'
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:1152: in function <.../AddOns/AllTheThings/src/UI/Classic Window Logic.lua:1143>
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:1201: in function `handler'
[string "@Interface/AddOns/AllTheThings/src/Events.lua"]:188: in function `HandleEvent'
[string "@Interface/AddOns/AllTheThings/src/Events.lua"]:197: in function <Interface/AddOns/AllTheThings/src/Events.lua:196>
[string "@Interface/AddOns/AllTheThings/lib/Callback.lua"]:22: in function <Interface/AddOns/AllTheThings/lib/Callback.lua:16>

Locals: (*temporary) = 0
(*temporary) = "table expected, got number"

To Reproduce
Update to latest (4.1.4a) version, enter World.

Expected behavior
No error. Also no information in the tooltip on items anymore.bb

Screenshots
image

@Goldenshacal
Copy link
Contributor

Thanks for the quick report, fix is out and att works again.
new att version will be on curse in a couple minutes

@ThaDanus
Copy link
Author

ThaDanus commented Nov 4, 2024

@Goldenshacal unfortunately I think something is still wrong, if I type /att ingame after upgrading to 4.1.5 I get

Message: ...ace/AddOns/AllTheThings/src/Classes/Item.Classic.lua:70: bad argument #1 to 'ipairs' (table expected, got number)
Time: Mon Nov  4 20:28:25 2024
Count: 1
Stack: ...ace/AddOns/AllTheThings/src/Classes/Item.Classic.lua:70: bad argument #1 to 'ipairs' (table expected, got number)
[string "=[C]"]: ?
[string "@Interface/AddOns/AllTheThings/src/Classes/Item.Classic.lua"]:70: in function <...ace/AddOns/AllTheThings/src/Classes/Item.Classic.lua:56>
[string "=(tail call)"]: ?
[string "@Interface/AddOns/AllTheThings/src/Classes/Item.Classic.lua"]:186: in function <...ace/AddOns/AllTheThings/src/Classes/Item.Classic.lua:185>
[string "=(tail call)"]: ?
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:70: in function <.../AddOns/AllTheThings/src/UI/Classic Window Logic.lua:29>
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:120: in function <.../AddOns/AllTheThings/src/UI/Classic Window Logic.lua:103>
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:48: in function <.../AddOns/AllTheThings/src/UI/Classic Window Logic.lua:29>
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:120: in function <.../AddOns/AllTheThings/src/UI/Classic Window Logic.lua:103>
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:48: in function <.../AddOns/AllTheThings/src/UI/Classic Window Logic.lua:29>
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:120: in function <.../AddOns/AllTheThings/src/UI/Classic Window Logic.lua:103>
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:48: in function <.../AddOns/AllTheThings/src/UI/Classic Window Logic.lua:29>
...
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:1616: in function `Show'
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:1225: in function `SetVisible'
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:1231: in function `Toggle'
[string "@Interface/AddOns/AllTheThings/src/UI/Classic Window Logic.lua"]:1966: in function `?'
[string "@Interface/AddOns/Blizzard_ChatFrameBase/Classic/ChatFrame.lua"]:5034: in function <.../AddOns/Blizzard_ChatFrameBase/Classic/ChatFrame.lua:4980>
[string "=[C]"]: in function `ChatEdit_ParseText'
[string "@Interface/AddOns/Blizzard_ChatFrameBase/Classic/ChatFrame.lua"]:4686: in function <.../AddOns/Blizzard_ChatFrameBase/Classic/ChatFrame.lua:4685>
[string "=[C]"]: in function `ChatEdit_SendText'
[string "@Interface/AddOns/Blizzard_ChatFrameBase/Classic/ChatFrame.lua"]:4722: in function `ChatEdit_OnEnterPressed'
[string "*ChatFrame.xml:120_OnEnterPressed"]:1: in function <[string "*ChatFrame.xml:120_OnEnterPressed"]:1>

Locals: (*temporary) = 0
(*temporary) = "table expected, got number"

And still no info on the tooltips either unfortunately.
Did a reinstall through curse to make sure I have 4.1.5 (doublechecked the version in AllTheThings.toc)

@NORPG NORPG reopened this Nov 4, 2024
@NORPG
Copy link
Member

NORPG commented Nov 4, 2024

I'm not sure which version u encountered this problem from, can you go back from 4.1.5?
If possible, please help us find a stable version without this issue.

@ThaDanus
Copy link
Author

ThaDanus commented Nov 4, 2024

4.1.3 is running stable without issues.
4.1.4 is also running stable (rolled back to 4.1.3 first because I encountered the issue with 4.1.4a)

@NORPG
Copy link
Member

NORPG commented Nov 4, 2024

This problem may not be solved soon, it is recommended to use a working version first.
I will research the problem again tomorrow, it seems to have nothing to do with localization changes, but a problem with cost changes.

@ThaDanus
Copy link
Author

ThaDanus commented Nov 4, 2024

Yeah no problem, thanks for all the hard work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants