fix: remove instrumentation of throw instruction #203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201
The changes remove instrumentation of
throw
because angetLogReturn
expects the return type of the method on top of the stack, however it receives a type of exception and hence it fails.If we want to instrument
throw
, we need to make sure we instrument with the correct type of exception.Bytecode
Source Code
https://github.com/ASSERT-KTH/collector-sahab-experiments/blob/4601a1dc0f9e8b5a616019fde76291dd3f7e33d7/Math-2/src/main/java/org/apache/commons/math3/distribution/AbstractIntegerDistribution.java#L101-L103