Upgrade mkdocs-material
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moving remaining TODOs to #39 |
|
Moving remaining style differences to #40 |
No box shadow or background on nav titles
jhkennedy
approved these changes
Oct 6, 2023
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| install_requires=[ | |||
| 'mkdocs', | |||
| 'mkdocs-material>=6.2.1,<7.0', | |||
| 'mkdocs-material==9.4.2', | |||
There was a problem hiding this comment.
@jtherrmann do we want to be this strict with the material version, or constrain to the major version?
There was a problem hiding this comment.
No idea, we should discuss this further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #27 for context
How to test these changes locally:
cdinto your local clone ofmkdocs-asf-theme.upgrade-mkdocs-materialbranch.cdinto your local clone ofhyp3-docs.upgrade-themebranch.hyp3-docsvirtual environment and runpip install -e ../mkdocs-asf-theme/.mkdocs serve.You can make changes to
mkdocs-asf-themeand then display them on thehyp3-docswebsite byCtrl+Cing and re-runningmkdocs serve.