Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release project site link fixes #33

Merged
merged 8 commits into from
Mar 25, 2021
Merged

Release project site link fixes #33

merged 8 commits into from
Mar 25, 2021

Conversation

jhkennedy
Copy link
Contributor

Developer checklist

  • Assigned a reviewer

  • Indicated the level of changes to this package by affixing one of these labels:

    • major -- Major changes to the API that may break current workflows
    • minor -- Minor changes to the API that do not break current workflows
    • patch -- Patches and bugfixes for the current version that do not break current workflows
    • bumpless -- Changes to documentation, CI/CD pipelines, etc. that don't affect the software's version

  • (If applicable) Updated the dependencies and indicated any downstream changes that are required

  • Updated CHANGELOG.md

  • Added/updated documentation for these changes

Reviewer checklist

  • Have all dependencies been updated?
  • Is the level of changes labeled appropriately?
  • Are all the changes described appropriately in CHANGELOG.md?
  • Has the documentation been adequately updated?

jhkennedy and others added 8 commits March 4, 2021 10:21
@jhkennedy
needs checkout
f37f221
@jhkennedy
Merge pull request #29 from ASFHyP3/workflow
35a4846 
Verify packaging needs checkout
@artisticlight
Update footer.html
1ab5e70 
I'm suggesting the leading slash be removed from this src path. It is resulting in the logo file not being found in https://asfadmin.github.io/asf-data-search-manual/

I'm not sure why this is working in HyP3, or is it?

Not sure, but it seems to be a problem in the search manual.
@jhkennedy
Merge pull request #30 from artisticlight/patch-1
34f848c 
Update footer.html suggestion. Please review and let's talk.
@jhkennedy
fix map
13b81ba
@jhkennedy
update changelog
8762ed0
@jhkennedy
Fix logo url for sub pages
e7be898
@jhkennedy
Merge pull request #31 from ASFHyP3/fix-links
030f934 
Fix footer map for project sites
@jhkennedy jhkennedy added the patch Bump the patch version number of this project label Mar 25, 2021
@jhkennedy jhkennedy requested review from a team and artisticlight March 25, 2021 02:46
@jhkennedy jhkennedy merged commit 2de58ce into main Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asjohnston-asf asjohnston-asf asjohnston-asf approved these changes

@artisticlight artisticlight Awaiting requested review from artisticlight

Assignees
No one assigned
Labels
patch Bump the patch version number of this project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhkennedy @asjohnston-asf @artisticlight