Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement changelog check without third-party action #157

Merged
merged 12 commits into from
Jun 13, 2024

Conversation

jtherrmann
Copy link
Contributor

@jtherrmann jtherrmann commented Jun 13, 2024

@jtherrmann jtherrmann added bumpless Changes to documentation, CI/CD pipelines, etc that don't affect the project's version and removed bumpless Changes to documentation, CI/CD pipelines, etc that don't affect the project's version labels Jun 13, 2024
@jtherrmann jtherrmann marked this pull request as ready for review June 13, 2024 23:37
@jtherrmann jtherrmann requested a review from a team as a code owner June 13, 2024 23:37
jhkennedy
jhkennedy previously approved these changes Jun 13, 2024
Copy link
Contributor

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I confirmed that it works as expected when adding and removing labels as well.

@jtherrmann jtherrmann changed the base branch from develop to main June 13, 2024 23:48
@jtherrmann jtherrmann dismissed jhkennedy’s stale review June 13, 2024 23:48

The base branch was changed.

@jtherrmann jtherrmann changed the base branch from main to develop June 13, 2024 23:49
@jtherrmann jtherrmann requested a review from jhkennedy June 13, 2024 23:51
@jtherrmann jtherrmann merged commit 2055b50 into develop Jun 13, 2024
1 check passed
@jtherrmann jtherrmann deleted the changelog-check branch June 13, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants