update types and descriptions for Terraform modules (Azure#408)

src/terraform/modules/jumpbox/variables.tf

@@ -29,6 +29,7 @@ variable "keyvault_name" {
 variable "tenant_id" {
   description = "The tenant ID of the keyvault to store jumpbox credentials in"
   type        = string
+  sensitive   = true
 }
 
 variable "object_id" {

src/terraform/modules/linux-virtual-machine/variables.tf

@@ -34,6 +34,7 @@ variable "admin_username" {
 variable "admin_password" {
   description = "The admin password of the virtual machine"
   type        = string
+  sensitive   = true
 }
 
 variable "publisher" {

src/terraform/modules/spoke/variables.tf

@@ -3,30 +3,37 @@
 
 variable "location" {
   description = "The region for spoke network deployment"
+  type        = string
 }
 
 variable "laws_location" {
   description = "Log Analytics Workspace location"
+  type        = string
 }
 
 variable "laws_workspace_id" {
   description = "Log Analytics Workspace workspace ID"
+  type        = string
 }
 
 variable "laws_resource_id" {
   description = "Log Analytics Workspace Azure Resource ID"
+  type        = string
 }
 
 variable "firewall_private_ip" {
   description = "Private IP of the Firewall"
+  type        = string
 }
 
 variable "spoke_rgname" {
   description = "Resource Group for the spoke network deployment"
+  type        = string
 }
 
 variable "spoke_vnetname" {
   description = "Virtual Network Name for the spoke network deployment"
+  type        = string
 }
 
 #################################
@@ -65,5 +72,6 @@ variable "subnets" {
 }
 
 variable "tags" {
-  type = map(string)
+  description = "A map of tags to add to all resources"
+  type        = map(string)
 }

src/terraform/modules/subnet/variables.tf

@@ -47,11 +47,23 @@ variable "nsg_name" {
 }
 
 variable "tags" {
-  type = map(string)
+  description = "A map of tags to add to all resources"
+  type        = map(string)
 }
 
 variable "nsg_rules" {
   description = "A collection of azurerm_network_security_rule"
+  type = map(object({
+    name                       = string
+    priority                   = string
+    direction                  = string
+    access                     = string
+    protocol                   = string
+    source_port_range          = string
+    destination_port_range     = string
+    source_address_prefix      = string
+    destination_address_prefix = string
+  }))
 }
 
 variable "routetable_name" {
@@ -66,21 +78,26 @@ variable "firewall_ip_address" {
 
 variable "log_analytics_storage_id" {
   description = "The id of the storage account that stores log analytics diagnostic logs"
+  type        = string
 }
 
 variable "log_analytics_workspace_id" {
   description = "The id of the log analytics workspace"
+  type        = string
 }
 
 variable "log_analytics_workspace_location" {
   description = "The location of the log analytics workspace"
+  type        = string
 }
 
 variable "log_analytics_workspace_resource_id" {
   description = "The resource id of the log analytics workspace"
+  type        = string
 }
 
 variable "flow_log_retention_in_days" {
   description = "The number of days to retain flow log data"
   default     = "7"
+  type        = number
 }

src/terraform/modules/virtual-network/variables.tf

@@ -3,22 +3,27 @@
 
 variable "location" {
   description = "The location/region to keep all your network resources. To get the list of all locations with table format from azure cli, run 'az account list-locations -o table'"
+  type        = string
 }
 
 variable "resource_group_name" {
   description = "A container that holds related resources for an Azure solution"
+  type        = string
 }
 
 variable "vnet_name" {
   description = "The name of the virtual network"
+  type        = string
 }
 
 variable "vnet_address_space" {
   description = "The address space to be used for the virtual network"
+  type        = list(string)
 }
 
 variable "log_analytics_workspace_resource_id" {
   description = "The resource ID of the Log Analytics Workspace to log events from the virtual network"
+  type        = string
 }
 
 variable "tags" {

src/terraform/modules/windows-virtual-machine/variables.tf

@@ -34,6 +34,7 @@ variable "admin_username" {
 variable "admin_password" {
   description = "The admin password of the virtual machine"
   type        = string
+  sensitive   = true
 }
 
 variable "publisher" {