Release 0.9.0 #27
Closed
Release 0.9.0 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westbury
force-pushed
the
release-0.9.0
branch
2 times, most recently
from
5d5735c to
384222b
Compare
mcgordonite
requested changes
Oct 25, 2019
There was a problem hiding this comment.
Nice to finally have an extension for Mercurial!
There's quite a lot of opportunity for code re-use between the git and hg extensions, but I don't think it's worth going much further until we know what Theia's SCM strategy will be.
Comments are just for low-handing fruit that I think will be quick to fix.
|
|
||
| // This implementation leaves all command servers running. There is no mechanism for shutting | ||
| // down command servers for repoistories that the user is no longer interacting with. | ||
| const commandServers: Map<string, HGRepo> = new Map(); |
There was a problem hiding this comment.
Rather than storing state in the module, it would be better to add an injectable class that tracks the command servers.
|
What are the teams plans for mercurial moving forward? |
Signed-off-by: Nigel Westbury <[email protected]> Clean up css class names and other code review changes
Signed-off-by: Nigel Westbury <[email protected]>
The version of TypeScript and @types/react used in mbs-ide are not compatible with the `event` type replaced by this commit. This commit can be reverted from ARMmbed/theia when: - Theia updates TS or @types/react such that the original code compiles - mbs-ide no longer uses @theia/scm in its workspace.
Shut down Mercurial command servers after 10 seconds of inactivity Clean out unneeded code Added test for HgCommandServer utils.
westbury
force-pushed
the
release-0.9.0
branch
from
0c38755 to
3784cfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR of the new Mercurial extension into a temporary branch so it can be reviewed. There is also a second commit that is a copy of the PR put into Theia. See eclipse-theia#6426 .