Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix travis astyle usage of .astyleignore #9267

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Fix travis astyle usage of .astyleignore #9267

merged 1 commit into from
Jan 7, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Jan 6, 2019

Description

Fixes issue #9266

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested a review from a team January 6, 2019 12:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 6, 2019

@orenc17, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 7, 2019

Thanks @orenc17 ! I see how this was missed (only changed files, and tested Pr did not change any 3rd party code that should not be checked).

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 7, 2019

CI started (restarted travis job as well)

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 7, 2019

Do you have Pr that would fail because of this bug ? or how was this tested?

@orenc17
Copy link
Contributor Author

orenc17 commented Jan 7, 2019

@0xc0170 my PR #9192 is introduces small changes in mbed-crypto but the entire file is detected by astyle

@0xc0170 0xc0170 merged commit 6fd0eea into ARMmbed:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orenc17 @ciarmcom @0xc0170