Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32: enable TICKLESS #9134

Merged
merged 2 commits into from
Dec 20, 2018
Merged

STM32: enable TICKLESS #9134

merged 2 commits into from
Dec 20, 2018

Conversation

jeromecoutant
Copy link
Collaborator

Description

I propose to enable TICKLESS for STM32 targets which are using LPTIM feature for LPTICKER.

This PR also update the LPTICKER_DELAY_TICKS to 4 according to #8783

NB: note that it is still possible to remove this tickless feature in you mbed_app.json file if needed/wanted:
ex:
"target_overrides": {
"NUCLEO_L476RG": {
"target.macros_remove": ["MBED_TICKLESS"]
},

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@jeromecoutant
Copy link
Collaborator Author

@c1728p9 @screamerbg

@cmonr
Copy link
Contributor

cmonr commented Dec 20, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 20, 2018

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

Copy link
Contributor

@screamerbg screamerbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will provide results for these families with tickless against Pelion tests soon.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 20, 2018

Can you review test logs for NUCLEO_F207ZG ? There are failures for all toolchains

@jeromecoutant
Copy link
Collaborator Author

Can you review test logs for NUCLEO_F207ZG ?

no... I don't have access to logs

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 20, 2018

The url above "Build artifacts" should be accessible:

Here's the link again:

Build artifacts

Browse to the tests, the target NUCLEO_F207ZG and you should see the logs there. If not, this is a bug that we should fix, please let us know

@jeromecoutant
Copy link
Collaborator Author

OK

2 comments:

  • F207 should not be affected by this PR

  • I checked 3 failed tests, and it seems they are not started... I don't understand why uart sync has failed.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 20, 2018

Thanks, CI restarted

Note, I restarted entire pipeline 🙄

@mbed-ci
Copy link

mbed-ci commented Dec 20, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 4d44e1c into ARMmbed:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants