Revert "Turn off MPU on targets failing OOB" #9020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@c1728p9, thank you for your changes. |
|
Marking this as |
The cause of the pelion-enablement test failures for Nuvoton boards is not caused by or related to the MPU so this patch re-enables the MPU for these boards. The cause of the pelion-enablement test failures for the UBLOX_C030_U201 has been identified and corrected so this patch re-enables the MPU for this board. This reverts commit b217c5f.
c1728p9
changed the title
|
@bulislaw Fyi |
|
@c1728p9 Making sure, is this still needed, or was this fixed in a different PR? |
|
@cmonr this just re-enables the MPU. It is not required for RC3 |
|
Test results with this PR: This should be safe to merge. |
adbridge
approved these changes
Dec 11, 2018
|
CI started |
|
Woop, I need to slow down. Stopped the wrong job. Restarting. |
|
CI started |
|
Fixes #8927 |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The cause of the pelion-enablement test failures for Nuvoton boards is not caused by or related to the MPU so this patch re-enables the MPU for these boards.
The change which initially disabled the MPU is:
b217c5f
Pull request type