Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align MBRBlockDevice writes to underlying BlockDevice write size #8262

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Align MBRBlockDevice writes to underlying BlockDevice write size #8262

merged 1 commit into from
Sep 28, 2018

Conversation

juhoeskeli
Copy link
Contributor

Description

When writing MBR the write buffer was allocated such that it would not align with BlockDevice write size resulting in failure of the write operation.

It would happen here:
err = bd->program(buffer, 512-buffer_size, buffer_size);

Now the buffer_size is calculated so that the writes will be properly aligned.

Tested with STM32L486 using internal flash as storage. Without fix it is not possible to initialise partition in the internal flash.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@cmonr cmonr requested review from geky and a team September 27, 2018 03:15
@JanneKiiskila
Copy link
Contributor

To next patch release, please.

Copy link
Contributor

@geky geky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect to me 👍
Thanks for this

@cmonr
Copy link
Contributor

cmonr commented Sep 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2018

Build : SUCCESS

Build number : 3184
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8262/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2018

@cmonr
Copy link
Contributor

cmonr commented Sep 27, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 28, 2018

@cmonr
Copy link
Contributor

cmonr commented Sep 28, 2018

sigh

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 28, 2018

Copy link
Contributor

@NirSonnenschein NirSonnenschein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants