Update CMSIS to 5.4.0 #7875

c1728p9 · 2018-08-23T21:48:39Z

Description

Pull in the newest version of CMSIS - 5.4.0.

In specific this patch does the following:

Preparation for importing
- Remove use of uVisor hooks
- Move Cortex A customization out for RTX and into mbed
- Update importer docs and cmsis_importer.json in prep for update
Run importer.py to pull in the updated version of RTX/CMSIS_5
Add additional RTX fixes
- ~~CMSIS/RTX: Conditionally enable TZ~~ CMSIS/RTX: Patch to conditionally compile
- CMSIS/RTX: Remove the file os_tick_gtim.c
- Fix define around EvrRtxKernelInitialized (Upstreamed into CMSIS_5)

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
[x] CMSIS update

cmonr · 2018-08-23T23:02:57Z

Testing.

/morph build

mbed-ci · 2018-08-23T23:35:19Z

Build : FAILURE

Build number : 2885
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7875/

0xc0170 · 2018-08-24T08:22:24Z

There are linker failures (does this change any API? I found at least one there: signalSet/wait in the CI logs).

donatieng

Looks like TCP/UDP tests use CMSIS-OS v1 APIs which are implemented in rtos/TARGET_CORTEX/rtx4/cmsis_os1.c which has been removed. Otherwise looks good :).

c1728p9 · 2018-08-24T21:22:50Z

I made the following changes:

updated cmsis_importer.json to include cmsis_os1.c
re-ran importer.py to pull in the updated version of RTX/CMSIS_5

deepikabhavnani · 2018-08-24T21:27:14Z

@ARMmbed/mbed-os-maintainers - Please note this PR will remove uVisor changes done on top of CMSIS, hence and should be merged after #7592

cmonr · 2018-08-24T22:47:22Z

@donatieng Mind taking an updated look?

Running CI to check if PR has improved.
/morph build

mbed-ci · 2018-08-24T23:52:39Z

Build : FAILURE

Build number : 2900
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7875/

c1728p9 · 2018-08-25T02:28:34Z

Updated this PR to fix IAR compilation.

cmonr · 2018-08-25T02:36:54Z

/morph build

mbed-ci · 2018-08-25T04:22:52Z

Build : FAILURE

Build number : 2905
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7875/

cmonr · 2018-08-25T13:16:45Z

Single failure, but unable to determine why...
/morph build

mbed-ci · 2018-08-25T14:26:17Z

Build : FAILURE

Build number : 2906
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7875/

c1728p9 · 2018-08-25T18:26:59Z

Replaced the commit "CMSIS/RTX: Conditionally enable TZ" with @deepikabhavnani 's
commit "CMSIS/RTX: Patch to conditionally compile" to fix TZ builds
on the NUMAKER_PFM_M2351.

cmonr · 2018-08-25T23:57:52Z

/morph build

Remove the double free RTOS tests since this was never defined behavior of CMSIS-RTOS. This allows testing to pass. The RTX commit which caused this test to start failing is: c3b123ef4256f65537e2597af475fc20ec9a383e RTX5: updated MemoryPoolFree (removed count check) [SDCMSIS-801] Note - Double freeing an element from a memory pool was never safe. The error return value when double freeing was misleading since memory corruption may still be occurring in that case. For more information on this see SDCMSIS-801.

c1728p9 · 2018-08-26T17:57:21Z

Remove the double free RTOS tests since this was never defined behavior of CMSIS-RTOS. This allows testing to pass.

The RTX commit which caused this test to start failing is:
ARM-software/CMSIS_5@c3b123e
RTX5: updated MemoryPoolFree (removed count check) [SDCMSIS-801]

Note - Double freeing an element from a memory pool was never safe. The error return value when double freeing was misleading since memory corruption may still be occurring in that case. For more information on this see SDCMSIS-801.

CC @RobertRostohar

c1728p9 · 2018-08-27T01:39:14Z

/morph build

mbed-ci · 2018-08-27T03:08:45Z

Build : FAILURE

Build number : 2911
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7875/

cmonr · 2018-08-27T03:11:50Z

The prep step got stuck somehow.

/morph build

mbed-ci · 2018-08-27T06:12:23Z

Build : SUCCESS

Build number : 2915
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7875/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-08-27T07:24:28Z

Exporter Build : SUCCESS

Build number : 2534
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7875/

mbed-ci · 2018-08-27T11:10:20Z

Test : FAILURE

Build number : 2664
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7875/2664

cmonr · 2018-08-27T13:44:34Z

Unclear if test failure was caused by PR or not.

/morph test

cmonr · 2018-08-27T19:51:10Z

@c1728p9 Would you be able to take a look at @donatieng comment? Is the file still not in the PR?

mbed-ci · 2018-08-27T19:56:10Z

Test : SUCCESS

Build number : 2670
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7875/2670

c1728p9 · 2018-08-27T20:11:48Z

Hi @cmonr I added cmsis_os1.c back to this PR earlier, so this should be good to go.

cmonr · 2018-08-27T22:04:28Z

@donatieng Mind re-reviewing? This PR should be good to go otherwise.

cmonr · 2018-08-30T20:56:44Z

@donatieng Mind re-reviewing/OKing?

mbed-ci · 2018-08-30T21:59:17Z

Build : SUCCESS

Build number : 2967
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7875/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-08-30T22:48:44Z

Exporter Build : SUCCESS

Build number : 2582
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7875/

mbed-ci · 2018-08-30T23:15:06Z

Exporter Build : SUCCESS

Build number : 2583
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7875/

mbed-ci · 2018-08-31T05:56:12Z

Test : SUCCESS

Build number : 2720
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7875/2720

donatieng

Looks good! Thanks @c1728p9

c1728p9 requested review from bulislaw, deepikabhavnani and 0xc0170 August 23, 2018 21:48

cmonr added the needs: review label Aug 23, 2018

cmonr added the release-version: 5.10.0-rc1 label Aug 24, 2018

0xc0170 requested review from donatieng and bulislaw and removed request for bulislaw August 24, 2018 08:20

0xc0170 added needs: work and removed needs: review labels Aug 24, 2018

donatieng suggested changes Aug 24, 2018

View reviewed changes

deepikabhavnani mentioned this pull request Aug 24, 2018

Removing unused rt_OsEventObserver #7635

Closed

c1728p9 force-pushed the feature_CMSIS_5_0b521765 branch from 46fb5c3 to 6d637c6 Compare August 24, 2018 21:22

cmonr added the needs: preceding PR label Aug 24, 2018

c1728p9 mentioned this pull request Aug 25, 2018

IAR compilation problem with __RESTRICT define ARM-software/CMSIS_5#415

Closed

c1728p9 force-pushed the feature_CMSIS_5_0b521765 branch from 7635c45 to f6ae178 Compare August 25, 2018 18:26

cmonr added needs: review and removed needs: work labels Aug 27, 2018

cmonr closed this Aug 27, 2018

0xc0170 removed the needs: review label Aug 27, 2018

cmonr reopened this Aug 30, 2018

cmonr added the needs: CI label Aug 30, 2018

donatieng approved these changes Aug 31, 2018

View reviewed changes

0xc0170 approved these changes Aug 31, 2018

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Aug 31, 2018

cmonr merged commit 00b7700 into ARMmbed:master Aug 31, 2018

0xc0170 removed the ready for merge label Aug 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update CMSIS to 5.4.0 #7875

Update CMSIS to 5.4.0 #7875

c1728p9 commented Aug 23, 2018 •

edited

Loading

cmonr commented Aug 23, 2018

mbed-ci commented Aug 23, 2018

0xc0170 commented Aug 24, 2018

donatieng left a comment

c1728p9 commented Aug 24, 2018

deepikabhavnani commented Aug 24, 2018

cmonr commented Aug 24, 2018

mbed-ci commented Aug 24, 2018

c1728p9 commented Aug 25, 2018

cmonr commented Aug 25, 2018

mbed-ci commented Aug 25, 2018

cmonr commented Aug 25, 2018

mbed-ci commented Aug 25, 2018

c1728p9 commented Aug 25, 2018

cmonr commented Aug 25, 2018

c1728p9 commented Aug 26, 2018

c1728p9 commented Aug 27, 2018

mbed-ci commented Aug 27, 2018

cmonr commented Aug 27, 2018

mbed-ci commented Aug 27, 2018

mbed-ci commented Aug 27, 2018

mbed-ci commented Aug 27, 2018

cmonr commented Aug 27, 2018

cmonr commented Aug 27, 2018

mbed-ci commented Aug 27, 2018

c1728p9 commented Aug 27, 2018

cmonr commented Aug 27, 2018

cmonr commented Aug 30, 2018

mbed-ci commented Aug 30, 2018

mbed-ci commented Aug 30, 2018

mbed-ci commented Aug 30, 2018

mbed-ci commented Aug 31, 2018

donatieng left a comment

Update CMSIS to 5.4.0 #7875

Update CMSIS to 5.4.0 #7875

Conversation

c1728p9 commented Aug 23, 2018 • edited Loading

Description

Pull request type

cmonr commented Aug 23, 2018

mbed-ci commented Aug 23, 2018

0xc0170 commented Aug 24, 2018

donatieng left a comment

Choose a reason for hiding this comment

c1728p9 commented Aug 24, 2018

deepikabhavnani commented Aug 24, 2018

cmonr commented Aug 24, 2018

mbed-ci commented Aug 24, 2018

c1728p9 commented Aug 25, 2018

cmonr commented Aug 25, 2018

mbed-ci commented Aug 25, 2018

cmonr commented Aug 25, 2018

mbed-ci commented Aug 25, 2018

c1728p9 commented Aug 25, 2018

cmonr commented Aug 25, 2018

c1728p9 commented Aug 26, 2018

c1728p9 commented Aug 27, 2018

mbed-ci commented Aug 27, 2018

cmonr commented Aug 27, 2018

mbed-ci commented Aug 27, 2018

Triggering tests

mbed-ci commented Aug 27, 2018

mbed-ci commented Aug 27, 2018

cmonr commented Aug 27, 2018

cmonr commented Aug 27, 2018

mbed-ci commented Aug 27, 2018

c1728p9 commented Aug 27, 2018

cmonr commented Aug 27, 2018

cmonr commented Aug 30, 2018

mbed-ci commented Aug 30, 2018

Triggering tests

mbed-ci commented Aug 30, 2018

mbed-ci commented Aug 30, 2018

mbed-ci commented Aug 31, 2018

donatieng left a comment

Choose a reason for hiding this comment

c1728p9 commented Aug 23, 2018 •

edited

Loading