LoRaWAN: Restoring default RX2 data rate #7831
Conversation
In #b0b0261 we changed the RX2 data rate to start from the highest data rate available for the PHY rather than standard defined DR. This introduced a regression, i.e., even when somebody changed the default RX2 data rate to something usable for their environment, it didn't take any effect. As in reset_mac_params() we override the data rate with max value possible for that PHY. This commit restores the original behaviour and we always use standard defined values.
|
@kivaisan @kjbracey-arm Please review. |
hasnainvirk
changed the title
|
@AnttiKauppila @cmonr Please review. |
|
/morph build |
Build : SUCCESSBuild number : 2846 Triggering tests/morph test |
Exporter Build : ABORTEDBuild number : 2473 |
Test : FAILUREBuild number : 2597 |
|
/morph test |
Exporter Build : SUCCESSBuild number : 2474 |
Test : SUCCESSBuild number : 2599 |
LoRaWAN: Restoring default RX2 data rate
Description
In b0b0261 we changed the RX2 data rate to start from the highest data rate
available for the PHY rather than standard defined DR.
This introduced a regression, i.e., even when somebody changed the default RX2 data
rate to something usable for their environment, it didn't take any effect. As in
reset_mac_params() we override the data rate with max value possible for that PHY.
This commit restores the original behaviour and we always use standard defined
values.
Pull request type