Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor enhancement to wait_us #7584

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Minor enhancement to wait_us #7584

merged 1 commit into from
Jul 26, 2018

Conversation

SenRamakri
Copy link
Contributor

Description

Minor enhancement to wait_us function to avoid integer division on all paths.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@SenRamakri SenRamakri mentioned this pull request Jul 23, 2018
Closed
@0xc0170 0xc0170 requested a review from a team July 25, 2018 08:22
cmonr
cmonr reviewed Jul 25, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but will wait for the commit message to be modified (git commit --amend) with a bit more detail.

Something like "Improved resolution of wait_us by defering division operation"

@SenRamakri
Copy link
Contributor Author

@cmonr - Please see my latest commit with modified commit message.

@cmonr
Copy link
Contributor

cmonr commented Jul 25, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 25, 2018

Build : SUCCESS

Build number : 2674
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7584/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 25, 2018

Exporter Build : SUCCESS

Build number : 2308
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7584/

@mbed-ci
Copy link

mbed-ci commented Jul 26, 2018

Test : SUCCESS

Build number : 2412
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7584/2412

@cmonr cmonr merged commit c5680b5 into ARMmbed:master Jul 26, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7584 from SenRamakri/sen_wait_us_Enhancement
0ef9fb5 
Minor enhancement to wait_us
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@cmonr cmonr cmonr approved these changes

@kjbracey kjbracey Awaiting requested review from kjbracey

Assignees
No one assigned
Labels
release-version: 5.9.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SenRamakri @cmonr @mbed-ci @0xc0170